p-token: Add interface and p-token to workspace #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
approved these changes
Mar 8, 2025
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Just nits, looks great otherwise!
p-token/Cargo.toml
Outdated
| name = "pinocchio-token-program" | ||
| version = "0.0.0" | ||
| edition = { workspace = true } | ||
| description = "A pinocchio-based Token program" |
Contributor
There was a problem hiding this comment.
wanna add "AKA p-token" to be clear?
Contributor
Author
There was a problem hiding this comment.
Good point – changed to:
description = "A pinocchio-based Token (aka 'p-token') program"
Merged
joncinque
approved these changes
Mar 10, 2025
Contributor
|
Force merging since CI will be fixed in the next one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Program
PR #22 added p-token interface and program but these are not currently on the cargo workspace.
Solution
Add both interface and p-token to the workspace.
Note
CI will be updated in a following PR.