Skip to content

p-token: Add interface and p-token to workspace #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 10, 2025
Merged

Conversation

febo
Copy link
Contributor

@febo febo commented Feb 6, 2025

Program

PR #22 added p-token interface and program but these are not currently on the cargo workspace.

Solution

Add both interface and p-token to the workspace.

Note

CI will be updated in a following PR.

@febo febo force-pushed the febo/workspace branch from 345f62f to 5f18723 Compare March 7, 2025 22:22
@febo febo marked this pull request as ready for review March 7, 2025 22:28
@febo febo requested a review from joncinque March 7, 2025 22:28
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits, looks great otherwise!

version = "0.0.0"
edition = { workspace = true }
description = "A pinocchio-based Token program"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanna add "AKA p-token" to be clear?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point – changed to:

description = "A pinocchio-based Token (aka 'p-token') program"

@joncinque joncinque mentioned this pull request Mar 8, 2025
@febo febo force-pushed the febo/workspace branch from 2500899 to b5e7827 Compare March 8, 2025 02:56
@febo febo enabled auto-merge (squash) March 10, 2025 13:47
@joncinque joncinque disabled auto-merge March 10, 2025 13:49
@joncinque
Copy link
Contributor

Force merging since CI will be fixed in the next one

@joncinque joncinque merged commit 5adaa0e into main Mar 10, 2025
10 of 11 checks passed
@febo febo deleted the febo/workspace branch March 10, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants