remove solana-program from program/src #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ok, tests should pass now as I've switched to an updated fork of mollusk |
joncinque
reviewed
Feb 25, 2025
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me, just the question about whether we should break the re-exports
Comment on lines
+16
to
+38
| /// Export current sdk types for downstream users building with a different sdk | ||
| /// version | ||
| pub mod solana_program { | ||
| #![allow(missing_docs)] | ||
| pub mod entrypoint { | ||
| pub use solana_program_error::ProgramResult; | ||
| } | ||
| pub mod instruction { | ||
| pub use solana_instruction::{AccountMeta, Instruction}; | ||
| } | ||
| pub mod program_error { | ||
| pub use solana_program_error::{PrintProgramError, ProgramError}; | ||
| } | ||
| pub mod program_option { | ||
| pub use solana_program_option::COption; | ||
| } | ||
| pub mod program_pack { | ||
| pub use solana_program_pack::{IsInitialized, Pack, Sealed}; | ||
| } | ||
| pub mod pubkey { | ||
| pub use solana_pubkey::{Pubkey, PUBKEY_BYTES}; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Do you think this is needed? With the crates now split up and following semver, I hope that we can stop doing these re-exports in program crates generally.
We can do a new major version for spl-token no problem.
Contributor
Author
There was a problem hiding this comment.
I would still like to break fewer things in a major release. This way hopefully very few people will need to change code
Contributor
There was a problem hiding this comment.
Fair enough! We can revisit then
joncinque
approved these changes
Feb 26, 2025
joncinque
added a commit
to joncinque/token-2022
that referenced
this pull request
Mar 4, 2025
#### Problem The token-2022 program still uses solana-program and solana-sdk, which are heavy dependencies. #### Summary of changes The component crates exist to do everything needed in token-2022, so we can remove solana-program usage entirely. NOTE: since some spl-token-2022's dependencies still use solana-program, there is no huge gain just yet. That will happen when we upgrade the upstream dependencies and then upgrade token-2022 to use those. Also NOTE: this is a breaking change since we've removed the re-export of the sdk types. Considering we're now respecting semver, this shouldn't be a problem, but we did add a version of re-exports in solana-program/token#26, so maybe we should do the same thing here. Let me know!
joncinque
added a commit
to solana-program/token-2022
that referenced
this pull request
Mar 5, 2025
* program: Remove solana-program / sdk #### Problem The token-2022 program still uses solana-program and solana-sdk, which are heavy dependencies. #### Summary of changes The component crates exist to do everything needed in token-2022, so we can remove solana-program usage entirely. NOTE: since some spl-token-2022's dependencies still use solana-program, there is no huge gain just yet. That will happen when we upgrade the upstream dependencies and then upgrade token-2022 to use those. Also NOTE: this is a breaking change since we've removed the re-export of the sdk types. Considering we're now respecting semver, this shouldn't be a problem, but we did add a version of re-exports in solana-program/token#26, so maybe we should do the same thing here. Let me know! * Fixup tests to run program in bpf mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for now as it needs a mollusk updateReady for reviewOne breaking change: the re-export of solana-program is replaced by a re-export of a few types. Hopefully for most users the re-export works as before