p-token: Add withdraw_excess_lamports instruction
#36
Conversation
febo
force-pushed
the
febo/withdraw-excess-lamports
branch
from
c81e695 to
6ee62a4
Compare
|
|
||
| use super::validate_owner; | ||
|
|
||
| #[inline(always)] |
There was a problem hiding this comment.
Totally separate from this PR, but what's the impact of these inlines? I wonder if there's a chance that we're actually making things worse by adding this annotation everywhere.
There was a problem hiding this comment.
In some cases it helps a lot – e.g., for transfer, inlining brings the CUs from 227 to 143.
But for others there is no difference in terms of CU, e.g., withdraw_excess_lamports, although it increases the program binary (+200 bytes).
I can revise all the inlines in a separate PR and only keep the ones that make a difference on the CUs. This way we can optimize both CU and program size.
There was a problem hiding this comment.
Ah interesting, I'm glad to see that it does help in some cases!
| let mut withdraw_ix = spl_token_2022::instruction::withdraw_excess_lamports( | ||
| &spl_token_2022::ID, | ||
| &account_pubkey, | ||
| &destination, | ||
| &owner.pubkey(), | ||
| &[], | ||
| ) | ||
| .unwrap(); | ||
| // Switches the program id to the token program. | ||
| withdraw_ix.program_id = token_program; |
There was a problem hiding this comment.
We should definitely relax the logic in spl-token-2022 to allow for spl-token::id as well
There was a problem hiding this comment.
We should do this when p-token is live, right?
There was a problem hiding this comment.
I think we can do it whenever, since it adoption of new library versions takes so long. But there's no rush either way
febo
force-pushed
the
febo/withdraw-excess-lamports
branch
from
539d06b to
43e8fce
Compare
Problem
As part of the migration to
p-token, it will be proposed to add thewithdraw_excess_lamportsinstruction – this is the same instruction that already exists in SPL Token-2022.Solution
This PR updates the
TokenInstructionenum to add aWithdrawExcessLamportsvariant with the same value as SPL Token-2022 and adds the processor implementation for the instruction.