Skip to content

p-token: Add spl-token test fixtures #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 14, 2025
Merged

p-token: Add spl-token test fixtures #39

merged 4 commits into from
Mar 14, 2025

Conversation

febo
Copy link
Contributor

@febo febo commented Mar 13, 2025

This PR adds a script to run spl-token fixtures against the p-token program (342 fixtures in total).

@febo febo marked this pull request as ready for review March 13, 2025 15:11
@febo febo requested review from buffalojoec and joncinque March 13, 2025 15:11
joncinque
joncinque reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but this is mostly a rubber-stamp since I'm less familiar with how to run fixture testing with mollusk. Please get Joe's approval

buffalojoec
buffalojoec reviewed Mar 13, 2025
View reviewed changes
BoomchainLabs

This comment was marked as spam.

Sign in to view

@febo febo requested a review from buffalojoec March 14, 2025 15:57
buffalojoec
buffalojoec approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@febo febo merged commit da8d9bd into main Mar 14, 2025
13 checks passed
@febo febo deleted the febo/fixtures branch March 14, 2025 16:37
BoomchainLabs
BoomchainLabs reviewed Mar 14, 2025
View reviewed changes
Copy link

@BoomchainLabs BoomchainLabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque left review comments

@BoomchainLabs BoomchainLabs BoomchainLabs approved these changes

@buffalojoec buffalojoec buffalojoec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@febo @joncinque @buffalojoec @BoomchainLabs