Skip to content

p-token: Clean-up test_case annotation #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: febo/mint-as-authority
Choose a base branch
from
Open

p-token: Clean-up test_case annotation #53

wants to merge 2 commits into from

Conversation

febo
Copy link
Contributor

@febo febo commented Apr 22, 2025

Problem

The tests on p-token used to run both SPL Token and p-token using the test_case crate as a "conformance" test. Since it now uses fixtures for that, the test_case annotation is redundant.

Solution

Clean-up the tests, removing the test_case annotation and dependency.

@febo febo changed the base branch from main to febo/mint-as-authority April 22, 2025 14:30
@febo febo marked this pull request as ready for review April 22, 2025 14:35
@febo febo requested a review from joncinque April 22, 2025 14:35
joncinque
joncinque approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@febo @joncinque