Skip to content

fix: return [] not null for empty accounts-mode meta.rewards #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notwedtm merged 2 commits into from
Jul 22, 2026
Merged

fix: return [] not null for empty accounts-mode meta.rewards #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3964338
fix: return [] not null for empty accounts-mode meta.rewards
Mctursh Jul 11, 2026
d7c427c
Merge branch 'main' into fix/accounts-rewards-empty-array
Mctursh Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/superbank-rpc/src/hydration/meta.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ pub(crate) fn build_transaction_status_meta_for_accounts(
"rewards populated without meta_rewards_present".to_string(),
));
}
None
Some(Vec::new())
};

let loaded_addresses = solana_sdk::message::v0::LoadedAddresses {
Expand Down
2 changes: 2 additions & 0 deletions crates/superbank-rpc/src/hydration/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ pub(crate) use block::hydrate_block_payload;
pub(crate) use errors::{BlockHydrationError, TransactionHydrationError};
#[cfg(any(test, feature = "grpc-streaming"))]
pub(crate) use meta::build_transaction_status_meta;
#[cfg(test)]
pub(crate) use meta::build_transaction_status_meta_for_accounts;
pub(crate) use meta::parse_transaction_error_display;
#[cfg(any(test, feature = "grpc-streaming"))]
pub(crate) use transaction::build_versioned_transaction;
Expand Down
16 changes: 16 additions & 0 deletions crates/superbank-rpc/src/tests/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ use std::sync::atomic::Ordering;
use std::time::Duration;
use tokio::sync::Semaphore;

use crate::clickhouse::StoredAccountsTransactionRecord;
use crate::clickhouse::{
BlockMetadataRecord, ClickHouseClient, ClickHouseClientOptions, RoutingPolicy, RoutingScope,
RoutingTransport, SignatureSlot, StoredBlockPayload, StoredBlockRecord,
Expand All @@ -48,6 +49,7 @@ use crate::handlers::transactions::handle_get_transactions_for_address;
use crate::handlers::types::MAX_GET_BLOCKS_RANGE;
use crate::hydration::BlockHydrationError;
use crate::hydration::build_transaction_status_meta;
use crate::hydration::build_transaction_status_meta_for_accounts;
use crate::hydration::{
TransactionHydrationError, build_versioned_transaction, hydrate_block_payload,
hydrate_block_record, hydrate_transaction_record, parse_instruction_error_display,
Expand Down Expand Up @@ -5994,6 +5996,20 @@ fn build_transaction_status_meta_emits_empty_lists_when_present() {
assert!(meta.rewards.as_ref().expect("rewards").is_empty());
}

#[test]
fn build_transaction_status_meta_for_accounts_emits_empty_rewards_when_absent() {
let mut record = base_transaction_record();
record.meta_pre_balances = vec![1];
record.meta_post_balances = vec![1];
let record: StoredAccountsTransactionRecord = record.into();

let meta = build_transaction_status_meta_for_accounts(&record)
.expect("build meta")
.expect("meta present");

assert!(meta.rewards.as_ref().expect("rewards").is_empty());
}

#[test]
fn hydrate_block_record_rejects_rewards_when_flag_false() {
let mut record = base_block_record(10);
Expand Down
Loading