Added updated SwisPowerShell from PS Gallery#401
Conversation
|
@MichalLudik could you review please? |
MichalLudik
left a comment
MichalLudik
left a comment
There was a problem hiding this comment.
Thank you for your contribution, @TobywL1 . Please, see the comment.
|
|
||
| # Copyright statement for this module | ||
| Copyright = '(c) 2016 SolarWinds, Inc.. All rights reserved.' | ||
| Copyright = 'Copyright © 1999-2026 SolarWinds Worldwide, LLC. All Rights Reserved.' |
There was a problem hiding this comment.
Nitpick: The official Copyright message on the SolarWinds website is, I quote: "©2026 SolarWinds Worldwide, LLC. All rights reserved." Could you update it, please?
There was a problem hiding this comment.
Hi @MichalLudik it seems there's a discrepancy with the formatting of the copyright line on PS Gallery https://www.powershellgallery.com/packages/SwisPowerShell/3.2.0.50065 - which should take precedent?
There was a problem hiding this comment.
@TobywL1, sorry for the confusion. I just found out that this version of the file never gets to the PowerShell Gallery. The values you attempted to change are used as placeholders in the internal build infrastructure. They are updated during the build process. You can check it by downloading the module and reviewing SwisPowerShell.psd1 and SwisPowerShell.nuspec files.
While I appreciate your contribution, I am rejecting the PR due to this.
There was a problem hiding this comment.
No worries @MichalLudik any chance the documentation can be updated as this may confuse others? In fact there are many aspects of this that are confusing including whole portions that say the SDK is community maintained, when in fact SWI have control over many parts of it :)
2 participants
Closes #396
Updated SwisPowerShell module from PS Gallery
Updated Release Notes section to better reflect version