fix(tests): widen timing budget on stays_pending / never_quiet fixtures#43
Merged
Conversation
Both ``tests/fixtures/test_browser.json`` cases set ``timeout_s: 0.05`` and assert ``evaluate.call_count >= 2``. The 50ms budget passes in CI's clean Linux container but flakes locally under CPU pressure: the loop's first iteration uses the whole budget on an interpreter under load, exits with call_count == 1, fails ``assert 1 >= 2``. Surfaced — and shipped past — during the v0.8.1 release.py run, which ran the full 1970-test suite. CI's per-job context made it invisible for prior releases; release.py's local full-suite run finally exposed it. Bumping to 0.5 gives 10× headroom, verified across three concurrent stress runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
kwschulz
added a commit
that referenced
this pull request
May 4, 2026
Bumps version 0.8.1 → 0.8.2 and finalizes the CHANGELOG section for the test-fixture timing fix that landed on main in PR #43. Cutting a patch release rather than carrying [Unreleased] forward: the fix surfaced during the v0.8.1 release flow, was framed as "pre-existing" at the time, and shipped past — bundling it into a future release would repeat the deferred-fix pattern v0.8.1's own changelog called out. Co-authored-by: Ken Schulz <kwschulz@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/fixtures/test_browser.jsonhadtimeout_s: 0.05for the two timing-loop cases that assertevaluate.call_count >= 2. The 50ms budget passes in CI's clean Linux container but flakes locally under CPU pressure (a single iteration consumes the whole budget on a busy interpreter), failing withassert 1 >= 2.release.pyruns the full 1970-test suite locally; the matrix CI's per-job isolation kept it invisible for prior releases. Bumping totimeout_s: 0.5gives 10× headroom.Test plan
pytest -v --no-covwith full 1970-test load →assert 1 >= 2onstays_pending1970 passed in 107.31sTestWaitForPendingData+TestWaitForNetworkQuiescence→ all greenscripts/ci-local.sh(matrix profile, isolated.venv-ci/) passes🤖 Generated with Claude Code