Skip to content

Add column for approved tests #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michielbdejong
Copy link
Collaborator

I also merged the 'crud' and 'wac' columns into a single 'Solid 0.9 (full suite)' column.

I also merged the 'crud' and 'wac' columns into a single 'Solid 0.9 (full suite)' column.
@michielbdejong
Copy link
Collaborator Author

To be clarified: should we list the tests that are currently in the specification-tests repo as already approved or as still unapproved?

Copy link

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specification tests repo contains tests for both the protocol spec and also the WAC spec (which also run against ACP) so its results don't fit a single column unless you split out its results.

However, please also note my response to solid-contrib/test-suite#142 where I suggest that we as a panel should not yet be publishing results.

As such I can't approve this PR in its current form.

@michielbdejong
Copy link
Collaborator Author

Got it.
Since the approved tests are all part of the specification-tests, which @edwardsph prefers and has promised we don't report results from, let's consider this blocked on solid-contrib/test-suite#142 for now. When we find a solution for that one, we can decide how to handle this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants