add typescript classes created with script for review#13
Conversation
src/solid/Agent.ts
Outdated
There was a problem hiding this comment.
I don't see any justification for generating mapping classes that lack properties.
When a shape would result in such then we should probably throw.
There was a problem hiding this comment.
added check with latest commit ce4907d - doesn't throw error but doesn't create class
src/solid/AccessControlResource.ts
Outdated
| @@ -0,0 +1,15 @@ | |||
| import { AcpAccessControl } from './AcpAccessControl'; | |||
There was a problem hiding this comment.
Don't we need .js at the end of these imports?
| this.overwrite("http://rdfs.org/sioc/ns#content", value, TermMapping.stringToLiteral); | ||
| } | ||
| get relatedChatChannel(): Set<string> { | ||
| return this.objects("n3-52", ValueMapping.literalToString, TermMapping.stringToLiteral); |
There was a problem hiding this comment.
The string used as predicate looks like a blank node label. I'm sure this is unintentional. It would not work.
It probably highlights some fundamental parser/generator problem in the converter.
There was a problem hiding this comment.
unresolved - the SHACL shape property from SolidOS uses [ sh:path [ sh:inversePath flow:message ]
[ sh:path [ sh:inversePath flow:message ] ;
sh:minCount 1 ;
rdfs:label "Related Chat" ;
rdfs:comment "The chat channel or conversation to which this message belongs." ;
sh:codeIdentifier "relatedChatChannel";
]
There was a problem hiding this comment.
Please remove redundant EOL comments.
|
https://github.com/solid/object/blob/main/src/solid/Container.ts compare with |
Branch created with Typescript classes created from SHACL shapes in https://github.com/solid/shapes using https://github.com/theodi/shacl-shape-converter-typescript