Skip to content

fix compiler warnings #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix compiler warnings #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions addresses/Addresses.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,18 +253,18 @@ contract Addresses is IAddresses, Test {
view
returns (
string[] memory names,
uint256[] memory chainIds,
uint256[] memory chainIdsList,
address[] memory addresses
)
{
uint256 length = recordedAddresses.length;
names = new string[](length);
chainIds = new uint256[](length);
chainIdsList = new uint256[](length);
addresses = new address[](length);

for (uint256 i = 0; i < length; i++) {
names[i] = recordedAddresses[i].name;
chainIds[i] = recordedAddresses[i].chainId;
chainIdsList[i] = recordedAddresses[i].chainId;
addresses[i] = _addresses[recordedAddresses[i].name][recordedAddresses[i]
.chainId].addr;
}
Expand All @@ -281,20 +281,20 @@ contract Addresses is IAddresses, Test {
view
returns (
string[] memory names,
uint256[] memory chainIds,
uint256[] memory chainIdsList,
address[] memory oldAddresses,
address[] memory newAddresses
)
{
uint256 length = changedAddresses.length;
names = new string[](length);
chainIds = new uint256[](length);
chainIdsList = new uint256[](length);
oldAddresses = new address[](length);
newAddresses = new address[](length);

for (uint256 i = 0; i < length; i++) {
names[i] = changedAddresses[i].name;
chainIds[i] = changedAddresses[i].chainId;
chainIdsList[i] = changedAddresses[i].chainId;
oldAddresses[i] = changedAddresses[i].oldAddress;
newAddresses[i] = _addresses[changedAddresses[i].name][changedAddresses[i]
.chainId].addr;
Expand Down
3 changes: 2 additions & 1 deletion mocks/MockAuction.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ contract MockAuction {
highestBid = msg.value;

if (previousBidder != address(0)) {
payable(previousBidder).call{value: msg.value}("");
(bool success, ) = payable(previousBidder).call{value: msg.value}("");
assert(success);
}
}

Expand Down
Loading