Draft: feat(tooltip): create Tooltip #79
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent of #73 since it has changes to
createFocusableThis is the port of Tooltip.
TODO
This is my first contribution to the project. I am looking for feedback.
I have pretty much followed what
@react-aria/tooltipis doing.I'm having a Typescript error with the return of
createTooltipTrigger.I'm getting this error:
Looking at the signature of
onFocusfromFocusEvents=>onFocus?: (e: FocusEvent) => void;in@solid-aria/types, this is exactly the same signature as we have in@react-aria/types. In their implementation ofonFocus, they are not passing the event toonFocusand it is not complaining in@react-ariaLooking at
createFocusableinterfaceFocusableResult,focusableProps: JSX.HTMLAttributes<any>;andonFocusinHTMLAttributesis indeedonFocus?: EventHandlerUnion<T, FocusEvent>;@fabien-ml I see you worked in
createFocusable, do you think you could help me out?