Add SSE primitive and transform utilities#831
Add SSE primitive and transform utilities#831davedbase merged 21 commits intosolidjs-community:mainfrom
Conversation
🦋 Changeset detectedLatest commit: b8fe38f The changes in this PR will be included in the next version bump. This PR includes changesets to release 50 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
It would be nice to separate changing emails from proposing a new primitive. |
Yeah, I was thinking about that as I was changing it. I reverted it back and will issue a separate PR. |
thetarnav
left a comment
There was a problem hiding this comment.
it's interesting to include the "transforms" here
that aren't related strictly to sse, they are just normal functions
but are small enough that it's probably fine
I mean I can not include them or move them somewhere more central. Technically I believe websocket could leverage them. Would it make sense to put them in utils? |
|
@thetarnav resolved your comments and moved transforms to utils. I think they will be generally useful in other packages. Not just websocket and sse. |
thetarnav
left a comment
There was a problem hiding this comment.
cool
I think it looks good
how to document utils is a separate issue though
Oh I added a simple section in the utils README for them. :) |
This PR adds server-sent events to the Solid Primitives project. I developed this for a project and went a bit further with it by adding optional Worker and built-in transform utilities. The goal was to make the package composable and flexible for many uses. I rather like the idea of the transforms and might add that into the websocket package as well.