Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export SearchParams #508

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

AlexErrant
Copy link
Contributor

SearchParams is on Location which is already exported. This PR makes it so I don't have to do Location['query'], e.g.

import { type Location } from '@solidjs/router'

export const someFn = (search: Location['query']) => { ... }

Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: a09ec2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ngdangtu-vn
Copy link

Just what I plan to do, thanks mate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants