Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move delegatecall logic from fallback function #226

Merged
merged 29 commits into from
Mar 18, 2025
Merged

Move delegatecall logic from fallback function #226

merged 29 commits into from
Mar 18, 2025

Conversation

0xCourtney
Copy link
Contributor

No description provided.

@0xCourtney 0xCourtney linked an issue Jul 28, 2023 that may be closed by this pull request
Move logic of fallback functions into an internal named function #222
Closed
@ItsNickBarry ItsNickBarry mentioned this pull request Mar 17, 2025
Merged
@ItsNickBarry ItsNickBarry changed the base branch from master to address-utils-custom-errors March 18, 2025 01:48
@ItsNickBarry
Copy link
Member

The _fallback function should not use AddressUtils because of the extra gas overhead. I've reverted that to inline delegatecall, but we can keep the new AddressUtils functions.

@ItsNickBarry ItsNickBarry marked this pull request as ready for review March 18, 2025 02:03
Base automatically changed from address-utils-custom-errors to master March 18, 2025 18:43
@ItsNickBarry ItsNickBarry merged commit 0570e16 into master Mar 18, 2025
@ItsNickBarry ItsNickBarry deleted the proxy branch March 18, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move logic of fallback functions into an internal named function
2 participants
@0xCourtney @ItsNickBarry