Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AccessControlDefaultAdminRules #228

Closed
wants to merge 38 commits into from
Closed

Added AccessControlDefaultAdminRules #228

wants to merge 38 commits into from

Conversation

paradoux
Copy link

@paradoux paradoux commented Oct 3, 2023 •
edited
Loading

This PR implements the AccessControlDefaultAdminRules contract from OpenZeppelin (See implementation here) following the patterns used by SolidState.

ItsNickBarry
ItsNickBarry requested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@ItsNickBarry ItsNickBarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts about replacing the default admin logic with an Ownable integration?

@paradoux paradoux requested a review from ItsNickBarry November 6, 2023 22:40
paradoux and others added 26 commits November 10, 2023 11:24
@paradoux
Refactor comment storage pointer
d62dc3a
@ItsNickBarry
Merge branch 'master' into paradoux-implement-access-control-extension
06b9068
@ItsNickBarry
update abi
7d09542
@ItsNickBarry
update version pragmas
8bd5919
@ItsNickBarry
Merge branch 'master' into paradoux-implement-access-control-extension
c0660bf
@ItsNickBarry
update pragma statements
25b3c4e
@ItsNickBarry
fix inheritance order
4a9ac8e
@ItsNickBarry
move storage libraries to storage directory
ea5f6f2
@ItsNickBarry
combine OwnableStorage and SafeOwnableStorage, rename to ERC173Storage
e0d176f
@ItsNickBarry
rename ERC165BaseStorage to ERC165Storage
9bcd711
@ItsNickBarry
combine ERC20 storage libraries into ERC20Storage
37dac4b
@ItsNickBarry
merge PartiallyPausableStorage into PausableStorage
be6a170
@ItsNickBarry
combine ERC1155 storage libraries into ERC115Storage
ce16368
@ItsNickBarry
combine ERC721 storage libraries into ERC721Storage
264745e
@ItsNickBarry
merge ERC1404BaseStorage and ERC4626BaseStorage into ERC20Storage
436ff15
@ItsNickBarry
rename NFTRoyaltyStorage to ERC2981Storage
7c55eec
@ItsNickBarry
rename DiamondBaseStorage to ERC2535Storage
a0e6011
@ItsNickBarry
rename ERC1271StoredStorage to ERC1271Storage
7e9da15
@ItsNickBarry
rename UpgradeableProxyStorage to ProxyStorage
0ba1a33
@ItsNickBarry
remove todo notes about renaming storage libraries
1e92ce1
@ItsNickBarry
merge BeaconProxyStorage into ProxyStorage
78f7227
@ItsNickBarry
add names to storage library mapping keys and values
ddcb835
@ItsNickBarry
use ERC names to disambiguate ERC20 storage variable context
3b5425c
@ItsNickBarry
simplify storage library filtering in inheritance tests
e0b5a9c
@ItsNickBarry
Merge branch 'consolidate-storage' into paradoux-implement-access-con…
0bd9d52 
…trol-extension
@ItsNickBarry
fix references to _AccessControl and _IAccessControl
aa24702
@ItsNickBarry ItsNickBarry changed the base branch from master to no-git-abi March 16, 2025 05:20
@ItsNickBarry ItsNickBarry deleted the branch solidstate-network:no-git-abi March 16, 2025 23:55
@ItsNickBarry
Copy link
Member

ItsNickBarry commented Mar 17, 2025 •
edited
Loading

I did not close this. I deleted the no-git-abi branch, but the base should have changed to master automatically. I'll open a new PR. At this rate, should be merged within a few days.

@ItsNickBarry ItsNickBarry mentioned this pull request Mar 17, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsNickBarry ItsNickBarry Awaiting requested review from ItsNickBarry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paradoux @ItsNickBarry