Fix CI #103
Merged
Fix CI #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solidus frontend doesn't have newer versions so specifying the branch for new versions won't work. If the branch is too high it will just error because it doesn't exist.
AlistairNorman
force-pushed
the
alistair/ci-check
branch
7 times, most recently
from
afd6e68 to
1c7d29e
Compare
AlistairNorman
force-pushed
the
alistair/ci-check
branch
3 times, most recently
from
9600f3f to
51511ce
Compare
AlistairNorman
force-pushed
the
alistair/ci-check
branch
3 times, most recently
from
c08e782 to
832d99a
Compare
Further information can be found in the Github issue. solidusio/solidus#6326
We were testing some pretty old versions here. In some cases they weren't compatible with each other.
The version of sqlite we use depends on which version of Rails we're on.
AlistairNorman
force-pushed
the
alistair/ci-check
branch
from
8976a97 to
823fc70
Compare
|
The number of fixup and wip commits in here tells this probably isn't actually ready for review. |
|
Did you manage to force push them out while I was typing that comment?? 
|
jarednorman
approved these changes
Oct 11, 2025
|
It might now actually be ready (if tests all pass) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.