Only load starter frontend decorators if they are available #175
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
sislr
approved these changes
Oct 14, 2025
| end | ||
|
|
||
| ::ProductsController.prepend(self) | ||
| if const_defined?('::HomeController') |
There was a problem hiding this comment.
Suggested change
| if const_defined?('::HomeController') | |
| if const_defined?('::ProductsController') |
Not everybody uses the starter frontend.
Rails does not create a sprockets manifest anymore, but we still depend on it. Since rails commands do not work anymore, because sprockets raises an error if no `manifest.js` file is present we need to create it in order to be able to run `rails new`.
tvdeyen
force-pushed
the
only-decorate-whats-available
branch
from
fd02066 to
3bb0401
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not everybody uses the starter frontend.