Skip to content

Conversation

@chaimann
Copy link
Contributor

@chaimann chaimann commented Apr 30, 2025

Summary

Create a UI alert component following guidelines from Figma.
Split from #6228, as we'd need a proper way to show errors, and usage of UI toasts to communicate errors is discouraged as per guideline:

When not to use:
Avoid using toast for error messages. Always try to use a banner to prominently inform merchants about persistent errors.

Other stuff

  • moved stimulus component controller from toast to controllers/alert_animation_controller as toast and alert share same animation behaviour;
  • added an extra colour sazerac: "#fcf0dd", which is the same as the one used in designs for background of a warning alert (rgba(253, 192, 113, 0.25)), but without alpha channel (which would make the background half-transparent); name sazerac comes from the UI colors utility where this color is labeled "Sazerac" (which appears to be the name of a cognac-based cocktail)

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (5c415e7) to head (74ca15d).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6226   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files         842      843    +1     
  Lines       18231    18240    +9     
=======================================
+ Hits        16202    16211    +9     
  Misses       2029     2029           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chaimann chaimann force-pushed the admin-ui-alert-component branch from f1eb2e1 to d144cc7 Compare May 5, 2025 15:03
@chaimann chaimann changed the title Admin UI alert component [Admin][UI] Alert component May 5, 2025
@chaimann chaimann force-pushed the admin-ui-alert-component branch 2 times, most recently from 27d17e2 to 83c6858 Compare May 5, 2025 16:28
@chaimann chaimann marked this pull request as ready for review May 5, 2025 17:07
@chaimann chaimann requested a review from a team as a code owner May 5, 2025 17:07
@chaimann chaimann force-pushed the admin-ui-alert-component branch 2 times, most recently from 75d3cd8 to cea851a Compare May 13, 2025 10:11
@chaimann chaimann force-pushed the admin-ui-alert-component branch from cea851a to 74ca15d Compare May 13, 2025 14:47
@chaimann chaimann mentioned this pull request May 14, 2025
4 tasks
@tvdeyen tvdeyen merged commit f55384c into solidusio:main May 21, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants