Allow promotion calculators to set dynamic adjustment labels #6398
+94
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, the `adjustment_label` method on
`SolidusPromotions::Benefit` could only output a relatively static
string. This commit allows calculators to define one of these methods:
- `#line_item_adjustment_label(line_item, options = {})`
- `#shipment_adjustment_label(shipment, options = {})`
- `#shipping_rate_adjustment_label(shipping_rate, options = {})`
- `#price_adjustment_label(price, options = {})`
These have access to the inner workings of the calculator, so they can
provide dynamic labels (to reflect e.g. which tier a promotion chooses,
making that transparent to the customer.
If a promotion calculator implements a dynamic
`#{adjustable}_adjustment_label` method, we need to update the
adjustment label when it changes. This makes sure that is the case.
github-actions
bot
added
the
changelog:solidus_promotions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6398 +/- ##
=======================================
Coverage 89.48% 89.48%
=======================================
Files 980 980
Lines 20438 20443 +5
=======================================
+ Hits 18289 18294 +5
Misses 2149 2149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows promotion calculators to compute labels for promotion adjustments based on properties of the item in question. This allows for example to have a different label if the quantity of a line item changes (interesting for quantity-based discounts).
Because those labels are now potentially more dynamic, we let the order adjuster update adjustment labels along with amounts.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: