-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds histogram prometheus metrics #112
Conversation
Waiting for approval from someone in the solo-io org to start testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you looked into native histograms as well? It's becoming more and more supported/adopted and can help with the problem of fixed sized buckets.
If we were to add this, this should go behind a flag that is disabled by default, keeping regular histograms as a default for now.
Co-authored-by: Krisztian Fekete <[email protected]>
Co-authored-by: Krisztian Fekete <[email protected]>
Co-authored-by: Krisztian Fekete <[email protected]>
Co-authored-by: Krisztian Fekete <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally, and it works.
Adds histogram prometheus metrics.
Users can specify histogram metrics using map type ringbuf by using the prefix
hist_
Histogram buckets, as well as the field containing the measurment value, can be provided as flags
-b/--hist-buckets
and-k/--hist-value-key
for example:
output:
Also fixes bug where chars would get decoded as ints