Adding Custom Pages #100
Merged
Adding Custom Pages #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Bucher <[email protected]>
|
Issues linked to changelog: |
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
toreysoloio
approved these changes
Sep 16, 2024
| ); | ||
| useEventListener(window, "resize", () => { | ||
| setWindowInnerWidth(window.innerWidth); | ||
| setWindowInnerHeight(window.innerHeight); |
There was a problem hiding this comment.
I like this being exposed via a context on app level
There was a problem hiding this comment.
Yep! I brought this over from GME.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for users to add custom pages. They can do this by adding the page files to the public folder, and then describing their custom pages in an environment variable. These custom pages can be Markdown or HTML.
Here is what it looks like if the page is not found:
Here is the
Markdown Example Page.Here is the
HTML Example Page.After taking those screenshots, I noticed the "Navigation" text was slightly off so that is fixed now.
BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/6860