Improves Rate Limit message accuracy, and fixes a bug with the deleted subscriptions status. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Bucher <[email protected]>
|
Issues linked to changelog: |
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
|
Issues linked to changelog: |
Signed-off-by: Nicholas Bucher <[email protected]>
Charlesthebird
changed the title
Signed-off-by: Nicholas Bucher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Please note that Subscriptions are able to override this Apps Rate Limit value.Please note that Subscriptions are able to override this Apps Rate Limit value. This App has ... Subscription(s).. Due to the fact that a second call must be made on the admin apps page, there is a new"View Rate Limit Information"button there.BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/7043
resolves https://github.com/solo-io/solo-projects/issues/7066