Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for homepage link #111

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix for homepage link #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/v0.0.38/api-page-reload-env-var-fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
changelog:
- type: FIX
description: >-
Fixes the API page reload behavior for the home page link.
3 changes: 2 additions & 1 deletion projects/ui/src/Components/Common/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export function Button(
props: {
color?: "primary" | "success" | "warning" | "danger" | "secondary";
variant?: "outline" | "subtle" | "light" | "filled";
tabIndex?: number;
onClick?: MouseEventHandler<HTMLButtonElement>;
/**
* `isText` defaults to true, and can be set to false to render the contents directly under the button.
Expand Down Expand Up @@ -95,7 +96,7 @@ export function Button(
// Render
//
return (
<MantineButton {...buttonProps}>
<MantineButton tabIndex={props.tabIndex} {...buttonProps}>
{!!isText ? (
<Text {...textProps}>{props.children}</Text>
) : (
Expand Down
8 changes: 6 additions & 2 deletions projects/ui/src/Components/Home/HomePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { HomePageCategoryCard } from "./HomePageCategoryCard";
import CardImage1 from "../../Assets/[email protected]";
import CardImage2 from "../../Assets/[email protected]";
import CardImage3 from "../../Assets/[email protected]";
import { onApisPageClick } from "../Structure/Header";

export function HomePage() {
const { isAdmin } = useContext(AuthContext);
Expand All @@ -27,8 +28,11 @@ export function HomePage() {
description={`Welcome to the ${companyName} Developer Portal. Connect, partner, and build with us to create the next generation of digital experiences.`}
additionalContent={
!isAdmin && (
<NavLink to="/apis">
<Button style={{ width: "150px", marginTop: "10px" }}>
<NavLink to="/apis" onClick={onApisPageClick}>
<Button
tabIndex={0}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabIndex=0 causes the button to not get focused by keyboard input (when tabbing through the page).

I added this since the link gets focused, and this is nested, so if it's not there it's a strange keyboard navigation experience.

style={{ width: "150px", marginTop: "10px" }}
>
VIEW APIS
</Button>
</NavLink>
Expand Down
Loading