Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional image url and logo customizations #90

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

Charlesthebird
Copy link
Collaborator

@Charlesthebird Charlesthebird commented Jul 17, 2024

This PR

  • Updates the environment variables so that the image URL's can be customized.
  • Updates the readme with how to use the new customization options, and adds some screenshots to it.
  • Updates the pagination controls so that they are only visible if needed (it looked strange to have them with only one API Product here).
  • Adds a VITE_COMPANY_NAME environment variable to customize the company name (this can be still done through tmplr variables like before, or manually, but the environment variable makes it consistent with the other customization options).
Screenshot 2024-07-17 at 3 01 01 PM Screenshot 2024-07-17 at 3 01 11 PM Screenshot 2024-07-17 at 3 01 22 PM

Resolves https://github.com/solo-io/gloo-mesh-enterprise/issues/17759

Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
@Charlesthebird Charlesthebird changed the title Charlesthebird/image url customizations Additional image url and logo customizations Jul 17, 2024
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
@Charlesthebird Charlesthebird marked this pull request as ready for review July 17, 2024 19:29
@Charlesthebird Charlesthebird merged commit d76ba4b into main Jul 17, 2024
2 checks passed
@Charlesthebird Charlesthebird deleted the charlesthebird/imageUrlCustomizations branch September 12, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants