Google Lighthouse Fixes #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
|
Issues linked to changelog: |
toreysoloio
approved these changes
Jul 19, 2024
| @@ -1,4 +1,4 @@ | |||
| <!DOCTYPE html> | |||
| <!doctype html> | |||
There was a problem hiding this comment.
huh; I never knew this should be lowercase
There was a problem hiding this comment.
I think this was actually a prettier fix, and not in the lighthouse score.
There was a problem hiding this comment.
Apparently it's not case sensitive, so it should be okay either way.
| width: 100%; | ||
| } | ||
| background-size: cover; | ||
| object-fit: cover; |
There was a problem hiding this comment.
Very nice! I actually used this once on a personal project once ages ago, but I 1000% forgot this existed; thanks for the reminder ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes fixes related to Google Lighthouse testing on the home and APIs pages. We have less control over the API details page since we use the Redoc and Swagger libraries for viewing the API schema, but these improvements carried over to that page as well.
roleattributes were removed.Results
Some of the suggestions are related to what the
VITE_PORTAL_SERVER_URLand image environment variables are set to, so those scores will depend on user configurations.The home page and APIs page had very similar scores, and improvements, so I will just include the home page scores here.
Before lighthouse fixes (on the home page):
lighthouse-before-improvements.pdf
After lighthouse fixes (on the home page):
lighthouse-after-improvements.pdf
BOT NOTES:
resolves https://github.com/solo-io/gloo-mesh-enterprise/issues/15009