-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charlesthebird/read only filesystem fix #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Issues linked to changelog: |
Signed-off-by: Nicholas Bucher <[email protected]>
…h script for testing the build + run process. Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
toreysoloio
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to Reproduce this Issue
sh hack/gateway-portal/portal-server-init.sh
portal-frontend
deployment, setspec.securityContext.readOnlyRootFilesystem: true
to see the yarn issues that arise during the UI build.Solution
For the dev-portal-starter, we do the UI build when the image is loaded, in order to get the latest environment variables from the deployment. This doesn't work in read-only environments. In our other UI's, like the GME UI, we do the UI build beforehand, and then make a request to the API for environment variables.
This PR adds a solution to this problem by adding a lightweight server to the UI image, which serves the UI and adds the environment variables with the EJS view engine. This makes it so that the portal server doesn't have to change to accommodate UI configuration, and the UI can stay mostly decoupled from it. This is important because:
Screenshots
Reproducing the Issue
Adding in


readOnlyFilesystem: true
reproduces the issue.Adding in the Fix
Keeping
readOnlyFilesystem: true
and updating the image to the version that is in this PR (gcr.io/solo-public/docs/portal-frontend:read-only-filesystem-test2
) fixes the issue.BOT NOTES:
resolves https://github.com/solo-io/gloo-mesh-enterprise/issues/18336