Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps card style updates, instructions for empty states, and loading circle flickering fix #97

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

Charlesthebird
Copy link
Collaborator

@Charlesthebird Charlesthebird commented Sep 6, 2024

This PR:

  • Updates the logic for showing instructions to the user when their Portal is set to private and they are logged out.
  • Updates the API details page to always show the docs tab, and adds in instructions to that tab if there are no docs for that API Product version.
  • Updates the landing pages so that they don't flicker (this mainly happened on the API's landing page). Was fixed by relying on the data instead of the loading property that SWR returns.
  • Updates the apps cards to look more like the teams cards. This was done because I got the feedback that the apps don't need images, so I decided to standardize them.

Here are some screenshots of the new UX improvements and teams cards updates.

Screenshot 2024-09-09 at 3 21 10 PM Screenshot 2024-09-09 at 3 22 57 PM Screenshot 2024-09-09 at 3 23 10 PM

BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/6853
resolves https://github.com/solo-io/solo-projects/issues/6852
resolves https://github.com/solo-io/solo-projects/issues/6851
resolves https://github.com/solo-io/solo-projects/issues/6854

Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
@Charlesthebird Charlesthebird marked this pull request as ready for review September 9, 2024 19:24
@Charlesthebird Charlesthebird changed the title Removing Apps placeholders, adding docs info, fixing loading state, and adding private portal info in Apps card style updates, adding in instructions to empty states, and flickering loading circle fix Sep 9, 2024
@Charlesthebird Charlesthebird changed the title Apps card style updates, adding in instructions to empty states, and flickering loading circle fix Apps card style updates, instructions for empty states, and loading circle flickering fix Sep 9, 2024
@Worfle Worfle merged commit 8d78eb4 into gg-portal-1.18-features Sep 9, 2024
3 checks passed
@Charlesthebird Charlesthebird deleted the charlesthebird/appsDocsLoadingFixes branch September 12, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants