App Details page: API Keys Section #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Bucher <[email protected]>
|
Issues linked to changelog: |
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Signed-off-by: Nicholas Bucher <[email protected]>
Worfle
approved these changes
Sep 11, 2024
| @@ -108,6 +108,16 @@ export type App = { | |||
| teamId: string; | |||
| }; | |||
|
|
|||
| export type ApiKey = { | |||
There was a problem hiding this comment.
I thought we already had this. Is this new or bringing it back?
There was a problem hiding this comment.
Yeah it's a throwback 😄 - we had this for the Gloo Mesh Gateway portal server.
With the new implementation of the Gloo Gateway portal server (the version we're moving to with these apps + teams features), it's slightly different. Luckily the code for it was mostly there, and all tested before, so I know that certain features like copyToClipboard should work across browsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Screen.Recording.2024-09-11.at.3.48.11.PM.mov
BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/6881