Dump logs for all containers when test fails (#10573)

solo-io · Jan 15, 2025 · 65196f5 · 65196f5
1 parent f7b6115
commit 65196f5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/changelog/v1.19.0-beta3/dump-all-containers-logs-on-test-fail.yaml b/changelog/v1.19.0-beta3/dump-all-containers-logs-on-test-fail.yaml
@@ -0,0 +1,6 @@
+changelog:
+  - type: NON_USER_FACING
+    description: >-
+      Added pod/container name prefix to log lines and make sure all containers are logged on test failure
+      skipCI-kube-tests:true
+      skipCI-docs-build:true
diff --git a/pkg/utils/statedumputils/state_dump.go b/pkg/utils/statedumputils/state_dump.go
@@ -298,7 +298,7 @@ func recordCRs(ctx context.Context, namespaceDir string, namespace string) error
 
 // kubeLogs runs $(kubectl -n $namespace logs $pod --all-containers) and returns the string result
 func kubeLogs(namespace string, pod string) (string, string, error) {
-	args := []string{"-n", namespace, "logs", pod, "--all-containers"}
+	args := []string{"-n", namespace, "logs", pod, "--all-containers=true", "--prefix=true"}
 	return kubeExecute(args)
 }