-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use v1beta1 for DestinationRules #10424
base: main
Are you sure you want to change the base?
Conversation
Issues linked to changelog: |
Visit the preview URL for this PR (updated for commit 18251c4): https://gloo-edge--pr10424-npolshak-use-v1beta1-oyuun8yu.web.app (expires Tue, 17 Dec 2024 17:00:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
Rerunning the |
The
|
https://github.com/solo-io/solo-projects/pull/7363 is potentially a dupe. |
Description
Use v1beta1 for DestinationRules to fix nightly tests failures that use Istio versions < 1.22.0.
API changes
NONE
Code changes
Change networkingclient in proxy syncer to use
istio.io/client-go/pkg/apis/networking/v1beta1
instead ofv1
which should be present for earlier Istio versions.CI changes
NONE
Docs changes
NONE
Context
#10399
Interesting decisions
We need to support earlier Istio versions, so adding a version check would limit our support matrix.
Testing steps
Proxy syncer tests are passing with switch
Notes for reviewers
More context: https://solo-io-corp.slack.com/archives/C06C8RA01NF/p1732570082933009
Checklist: