Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1beta1 for DestinationRules #10424

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

npolshakova
Copy link

Description

Use v1beta1 for DestinationRules to fix nightly tests failures that use Istio versions < 1.22.0.

API changes

NONE

Code changes

Change networkingclient in proxy syncer to use istio.io/client-go/pkg/apis/networking/v1beta1 instead of v1 which should be present for earlier Istio versions.

CI changes

NONE

Docs changes

NONE

Context

#10399

Interesting decisions

We need to support earlier Istio versions, so adding a version check would limit our support matrix.

Testing steps

Proxy syncer tests are passing with switch

Notes for reviewers

More context: https://solo-io-corp.slack.com/archives/C06C8RA01NF/p1732570082933009

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@solo-changelog-bot
Copy link

Issues linked to changelog:
#10399

Copy link

github-actions bot commented Dec 2, 2024

Visit the preview URL for this PR (updated for commit 18251c4):

https://gloo-edge--pr10424-npolshak-use-v1beta1-oyuun8yu.web.app

(expires Tue, 17 Dec 2024 17:00:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@danehans
Copy link

danehans commented Dec 4, 2024

Rerunning the Kubernetes Tests / End-to-End (cluster-six) job due to #10434.

@danehans
Copy link

danehans commented Dec 4, 2024

The Unit Tests / projects/gateway2 (pull_request) job is failing b/c the testdata in projects/gateway2/setup must be updated to support the v1beta1 API version. After updating the testdata, follow the steps in the readme to regenerate the *-out.yaml:

  1. Remove the existing generated testdata outputs rm -rf projects/gateway2/setup/testdata/*-out.yaml
  2. Run TEST_PKG=./projects/gateway2/setup make go-test. This will fail but it regenerates the *-out.yaml files.
  3. Run TEST_PKG=./projects/gateway2/setup make go-test. This should pass.

@danehans
Copy link

danehans commented Dec 4, 2024

https://github.com/solo-io/solo-projects/pull/7363 is potentially a dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants