-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation #10710
base: main
Are you sure you want to change the base?
Update documentation #10710
Conversation
Issues linked to changelog: |
Visit the preview URL for this PR (updated for commit fae0697): https://gloo-edge--pr10710-aws-lambda-429-docum-n88nxjno.web.app (expires Thu, 27 Mar 2025 00:52:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
@@ -324,3 +324,6 @@ Wrap the request to the function in the same way as an AWS API Gateway. | |||
{"body": "gloo edge is inserting this body", "headers": {":authority": "localhost:8080", ":method": "POST", ":path": "/", ":scheme": "http", "accept": "*/*", "content-length": "32", "content-type": "application/x-www-form-urlencoded", "test-header-key": "test-header-value", "user-agent": "curl/7.85.0", "x-forwarded-proto": "http", "x-request-id": "347975da-fa61-4d8a-9285-ee0826202819"}, "httpMethod": "POST", "isBase64Encoded": false, "multiValueHeaders": null, "multiValueQueryStringParameters": null, "path": "/", "pathParameters": null, "queryStringParameters": null, "requestContext": {"httpMethod": "POST", "path": "/", "protocol": "HTTP/1.1", "resourcePath": "/"}, "resource": "/", "routeKey": "POST /", "stageVariables": null, "version": "1.0"}% | |||
``` | |||
|
|||
##### Rate-limited Lambda Function | |||
|
|||
If the upstream Lambda destination is rate-limited, AWS will send a 429 response to Gloo. In this case, Gloo Gateway will change the status code to `500`. Additionally, it will set the `X-Envoygloo-Lambda-Statuscode` header to `429`, and the `X-Envoygloo-Lambda-Statusreason` header will be set with the reason the Lambda function was throttled. For more information, see the [AWS Lambda Documentation](https://docs.aws.amazon.com/lambda/latest/api/API_Invoke.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this take affect by default? or is this only with a certain setting like a unwrap function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think this is correct
@@ -324,3 +324,6 @@ Wrap the request to the function in the same way as an AWS API Gateway. | |||
{"body": "gloo edge is inserting this body", "headers": {":authority": "localhost:8080", ":method": "POST", ":path": "/", ":scheme": "http", "accept": "*/*", "content-length": "32", "content-type": "application/x-www-form-urlencoded", "test-header-key": "test-header-value", "user-agent": "curl/7.85.0", "x-forwarded-proto": "http", "x-request-id": "347975da-fa61-4d8a-9285-ee0826202819"}, "httpMethod": "POST", "isBase64Encoded": false, "multiValueHeaders": null, "multiValueQueryStringParameters": null, "path": "/", "pathParameters": null, "queryStringParameters": null, "requestContext": {"httpMethod": "POST", "path": "/", "protocol": "HTTP/1.1", "resourcePath": "/"}, "resource": "/", "routeKey": "POST /", "stageVariables": null, "version": "1.0"}% | |||
``` | |||
|
|||
##### Rate-limited Lambda Function | |||
|
|||
If the upstream Lambda destination is rate-limited, AWS will send a 429 response to Gloo. In this case, Gloo Gateway will change the status code to `500`. Additionally, it will set the `X-Envoygloo-Lambda-Statuscode` header to `429`, and the `X-Envoygloo-Lambda-Statusreason` header will be set with the reason the Lambda function was throttled. For more information, see the [AWS Lambda Documentation](https://docs.aws.amazon.com/lambda/latest/api/API_Invoke.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the target Lambda function is rate-limited, AWS sends back a 429 HTTP response code to Gloo Gateway. Gloo Gateway changes the 429 HTTP response code to 500. In addition, Gloo Gateway sets the X-Envoygloo-Lambda-Statuscode
header to 429
and the X-Envoygloo-Lambda-Statusreason
header to the reason the Lambda function was throttled. For more information, see the AWS Lambda Documentation.
Description
Update AWS Lambda documentation to explain how Gloo behaves when Lambda functions are rate-limited.
API changes
Code changes
CI changes
Docs changes
Context
Interesting decisions
Testing steps
Notes for reviewers
Checklist: