Add cluster info gatherer for the upcoming Ambient mesh migration-estimation page #1
Conversation
inFocus7
changed the title
…targets for validity of scripts
inFocus7
changed the title
There was a problem hiding this comment.
Overall LGTM! Few nits / couple questions:
- Let's move known TODOs into GH issues so we can track & prioritize appropriately.
- Anecdotally, did we end up saving much time from adding parallelism when run against the same example clusters?
- I ran this locally on my ARM Mac and it worked great. Can we confirm it also works fine when run from linux?
TODO(me): after this merges, look into how to route a run.solo.io/ to the script.
I can help you set this up, this is handled by one of our infra clusters, should be super quick once we have the url to this committed file on main.
| @@ -0,0 +1,601 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
When I cloned this repo and tried to run this, I had to chmod +x this file - this is something we can commit to the repo.
There was a problem hiding this comment.
Ah thanks, I thought I ran this before 🤦🏼
Co-authored-by: Rachael Graham <[email protected]>
| elif test("^[0-9]+Ti$") then | ||
| (.[0:-2] | tonumber) * 1024 * 1024 * 1024 * 1024 |
There was a problem hiding this comment.
Looking around it seems like jq uses C++ doubles to represent numbers. I think these numbers are within the maximum capacity of a double, but they certainly exceed the numbers that can be represented exactly with a double. That may not be a problem, but it's good to be aware of.
| if command -v nproc > /dev/null; then | ||
| CORES=$(nproc) | ||
| MAX_PARALLEL=$((CORES > 8 ? 8 : CORES)) | ||
| log_info "System has $CORES cores, using $MAX_PARALLEL parallel processes for namespace processing" |
There was a problem hiding this comment.
If we wouldn't be running in parallel (i.e. MAX_PARALLEL=1), it would probably be nice not to log messages implying that we are. But that seems like a good candidate for something to do in a follow-up / never.
TODO(me): after this merges, look into how to route a
run.solo.io/<something>to the script.# AMBIENT MESH MIGRATION TOOL.md
semi-recent demo (before parallelization): https://solo.zoom.us/rec/share/_L8eKVpIcICLcQoi_gpld7mC8c3ZNTNO3QT4bZSJYYdCNwdAwq2GVtIHX2ShIsQB.EQEzF1burT5m4f0q?startTime=1742319075000&pwd=WMcybNCxjmMkrWFkqbXduFT75tOfrJbh