Open
Conversation
adriresu
force-pushed
the
15.0-mig-helpdesk_mgmt_timesheet_addline
branch
from
ce1045d to
1cbd7f1
Compare
dalonsod
requested changes
Nov 2, 2023
Contributor
dalonsod
left a comment
dalonsod
left a comment
There was a problem hiding this comment.
See comment. Once applied that patch, locally tested in a brand new database 👍
adriresu
force-pushed
the
15.0-mig-helpdesk_mgmt_timesheet_addline
branch
from
1cbd7f1 to
49c9343
Compare
Contributor
|
Please reword commit message |
adriresu
force-pushed
the
15.0-mig-helpdesk_mgmt_timesheet_addline
branch
from
49c9343 to
112301b
Compare
Author
|
Name fixed |
Contributor
|
@Anxo82 with this new addition, button is shown twice, isn't it? I'd prefer only moving it, so you can remove it from original location above timesheets grid |
dalonsod
requested changes
Jan 2, 2024
Contributor
dalonsod
left a comment
dalonsod
left a comment
There was a problem hiding this comment.
@Anxo82 See comment, and also, in separate commits:
- [FIX] This button should be only available if timesheets are allowed for the ticket (see timesheets page invisible condition within ticket form).
- [UPD] View files have unconventional names, because, they should be respectively moved to
hr_timesheet_views.xml(oraccount_analytic_line_views.xml) andhelpdesk_ticket_views.xml, as models are named.
| <xpath expr="//button[@name='assign_to_me']" position="after" > | ||
| <button string="Create new timesheet" | ||
| name="%(helpdesk_mgmt_timesheet_addline.action_new_timesheet)d" | ||
| class="oe_edit_only btn-primary" |
Contributor
There was a problem hiding this comment.
Tested, button is hidden even if ticket exists, when mode is not editable, maybe for this class. Could you remove it and try?
Suggested change
| class="oe_edit_only btn-primary" | |
| class="btn-primary" |
Anxo82
force-pushed
the
15.0-mig-helpdesk_mgmt_timesheet_addline
branch
from
dc4c39d to
0e92082
Compare
Anxo82
force-pushed
the
15.0-mig-helpdesk_mgmt_timesheet_addline
branch
from
0e92082 to
61136bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.