[13.0][ADD] helpdesk_mgmt_ticket_invoice#40
Open
IriaAlonso wants to merge 1 commit into13.0from
Open
Conversation
Contributor
IriaAlonso
commented
Sep 18, 2024
IriaAlonso
commented
- Add a relation between tickets and invoices
- Button that shows all related tickets
- Button that creates a ticket from the invoice (in progress)
IriaAlonso
force-pushed
the
13.0-add-helpdesk_mgmt_ticket_invoice
branch
2 times, most recently
from
a270fd3 to
1eaa8ea
Compare
Contributor
Author
|
@dalonsod can u review it? |
IriaAlonso
force-pushed
the
13.0-add-helpdesk_mgmt_ticket_invoice
branch
from
1eaa8ea to
eeb888f
Compare
Contributor
|
I'll check it later... @ChristianSantamaria could you review first? |
ChristianSantamaria
requested changes
Sep 20, 2024
ChristianSantamaria
left a comment
ChristianSantamaria
left a comment
There was a problem hiding this comment.
Code review, a few improvements 😃
IriaAlonso
force-pushed
the
13.0-add-helpdesk_mgmt_ticket_invoice
branch
from
eeb888f to
8a67c45
Compare
Contributor
Author
|
@dalonsod changes done |
dalonsod
requested changes
Sep 26, 2024
Contributor
dalonsod
left a comment
dalonsod
left a comment
There was a problem hiding this comment.
See my initial comments
IriaAlonso
force-pushed
the
13.0-add-helpdesk_mgmt_ticket_invoice
branch
2 times, most recently
from
38dd48b to
06d80cc
Compare
Contributor
Author
|
@dalonsod changes done 👍 |
dalonsod
requested changes
Sep 27, 2024
IriaAlonso
force-pushed
the
13.0-add-helpdesk_mgmt_ticket_invoice
branch
from
06d80cc to
c8503ee
Compare
Contributor
Author
|
@dalonsod changes done |
dalonsod
reviewed
Sep 27, 2024
|
|
||
| def _compute_count_ticket_ids(self): | ||
| for record in self: | ||
| record.count_ticket_ids = record.count_ticket_ids = len(record.ticket_ids) |
Contributor
There was a problem hiding this comment.
Please remove unnecessary code:
Suggested change
| record.count_ticket_ids = record.count_ticket_ids = len(record.ticket_ids) | |
| record.count_ticket_ids = len(record.ticket_ids) |
dalonsod
reviewed
Sep 27, 2024
| <field name="inherit_id" ref="helpdesk_mgmt.ticket_view_form" /> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="//field[@name='tag_ids']" position="after"> | ||
| <field name="type" invisible="1"/> |
Contributor
There was a problem hiding this comment.
Try to remove this field (even in python definition), as actually unneeded (not sure).
dalonsod
reviewed
Sep 27, 2024
IriaAlonso
force-pushed
the
13.0-add-helpdesk_mgmt_ticket_invoice
branch
from
c8503ee to
cde5a6b
Compare
IriaAlonso
force-pushed
the
13.0-add-helpdesk_mgmt_ticket_invoice
branch
from
cde5a6b to
d3241d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.