[17.0][MIG] hr_leave_attach_autovalidated: Migration to 17.0#23
Open
DantePereyra wants to merge 3 commits into17.0from
Open
[17.0][MIG] hr_leave_attach_autovalidated: Migration to 17.0#23DantePereyra wants to merge 3 commits into17.0from
DantePereyra wants to merge 3 commits into17.0from
Conversation
Allow to attach files on autovalidated absences.
DantePereyra
force-pushed
the
17.0-mig-hr_leave_attach_autovalidated
branch
from
377d3b5 to
a6d0833
Compare
ChristianSantamaria
requested changes
Jan 16, 2026
Contributor
ChristianSantamaria
left a comment
ChristianSantamaria
left a comment
There was a problem hiding this comment.
Code review, and minor change..
| def _check_leave_attachment_delete(self): | ||
| for attach in self: | ||
| if (attach.res_model == 'hr.leave' and attach.res_id): | ||
| hr_leave_id = self.env['hr.leave'].browse(attach.res_id) |
Contributor
There was a problem hiding this comment.
To avoid so many changes appearing in the commit, you could use the old name the variable had.
DantePereyra
force-pushed
the
17.0-mig-hr_leave_attach_autovalidated
branch
from
a6d0833 to
e8fdae6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard migration.