[17.0][MIG] hr_leave_has_attachment: Migration to 17#25
Open
DantePereyra wants to merge 5 commits into17.0from
Open
[17.0][MIG] hr_leave_has_attachment: Migration to 17#25DantePereyra wants to merge 5 commits into17.0from
DantePereyra wants to merge 5 commits into17.0from
Conversation
Adds new field to hr.leave model to check if there are any attachments.
The 'hr_leave_attach_autovalidated' addon allow to delete an attachment, but this addon modify the unlink() method editing the attachment, giving permissions error. Adding the sudo() allow to edit the attachment, fixing this problem.
DantePereyra
force-pushed
the
17.0-mig-hr_leave_has_attachment
branch
from
bc7001b to
d5162cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard migration.
I'm not sure how to test
@api.ondelete, could you check @ChristianSantamaria? Thanks!