Skip to content

[15.0][IMP] mrp_project_analytic_purchase: change function due to improved mrp_project_analytic#116

Open
ChristianSantamaria wants to merge 1 commit into15.0from
15.0-imp-mrp_project_analytic_purchase
Open

[15.0][IMP] mrp_project_analytic_purchase: change function due to improved mrp_project_analytic#116
ChristianSantamaria wants to merge 1 commit into15.0from
15.0-imp-mrp_project_analytic_purchase

Conversation

@ChristianSantamaria
Copy link
Copy Markdown
Contributor

Change function due to improved mrp_project_analytic

@dalonsod dalonsod force-pushed the 15.0-imp-mrp_project_analytic_purchase branch from 513373d to 8da0d86 Compare May 19, 2025 16:46
@dalonsod
Copy link
Copy Markdown
Contributor

@ChristianSantamaria rebase made due to #117 and #118

Copy link
Copy Markdown
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this:

  • _get_from_child_acount_move_lines() is called from mark_analytic_mrp_from_child() for a certain productiom.
  • So the code that obtain a new set of journal items and set for them the new check analytic_mrp_from_purchase could be simply moved from _get_from_child_acount_move_lines() to mark_analytic_mrp_from_child().
  • With this refactoring, _get_from_child_acount_move_lines() will still represent a getter method, and not a getter & updater method.

What do you think @ChristianSantamaria ?

@ChristianSantamaria ChristianSantamaria force-pushed the 15.0-imp-mrp_project_analytic_purchase branch from 8da0d86 to f4c5477 Compare May 20, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants