[15.0][IMP] mrp_project_analytic_purchase: change function due to improved mrp_project_analytic#116
Open
ChristianSantamaria wants to merge 1 commit into15.0from
Open
Conversation
513373d to
8da0d86
Compare
Contributor
|
@ChristianSantamaria rebase made due to #117 and #118 |
dalonsod
requested changes
May 19, 2025
Contributor
There was a problem hiding this comment.
I see this:
_get_from_child_acount_move_lines()is called frommark_analytic_mrp_from_child()for a certain productiom.- So the code that obtain a new set of journal items and set for them the new check
analytic_mrp_from_purchasecould be simply moved from_get_from_child_acount_move_lines()tomark_analytic_mrp_from_child(). - With this refactoring,
_get_from_child_acount_move_lines()will still represent a getter method, and not a getter & updater method.
What do you think @ChristianSantamaria ?
…mrp_project_analytic
8da0d86 to
f4c5477
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change function due to improved mrp_project_analytic