Skip to content

[17.0][ADD] sale_order_net_price_control#104

Open
IriaAlonso wants to merge 2 commits into17.0from
17.0-add-sale_order_net_price_control
Open

[17.0][ADD] sale_order_net_price_control#104
IriaAlonso wants to merge 2 commits into17.0from
17.0-add-sale_order_net_price_control

Conversation

@IriaAlonso
Copy link
Copy Markdown
Contributor

@IriaAlonso IriaAlonso commented Jun 5, 2025 •
edited
Loading

PHASE 2 DEVELOPMENT --> fix --> done

  • Additional control of ‘base reference tariff for minimum price control’ (that will be that MAYM tariff).
  • That tariff will be a res.config.settings, per company then.
  • That tariff will also have to be checked (find out the price and compare with it, just as we do with the last price in invoice purchase)
    HT00356

add description, readme and index --> done
add commit description

@IriaAlonso IriaAlonso force-pushed the 17.0-add-sale_order_net_price_control branch from 164e8dc to 95b2853 Compare June 9, 2025 12:53
@IriaAlonso
Copy link
Copy Markdown
Contributor Author

IriaAlonso commented Jun 10, 2025

@dalonsod can you review it?

dalonsod
dalonsod requested changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Comment thread sale_order_net_price_control/models/res_config_settings.py Outdated
Comment thread sale_order_net_price_control/models/sale_order_line.py Outdated
Comment thread sale_order_net_price_control/models/sale_order_line.py Outdated
Comment thread sale_order_net_price_control/models/sale_order_line.py Outdated
Comment thread sale_order_net_price_control/models/sale_order_line.py Outdated
Comment thread sale_order_net_price_control/models/sale_order_line.py Outdated
@IriaAlonso IriaAlonso force-pushed the 17.0-add-sale_order_net_price_control branch 3 times, most recently from 11f850d to 7223a5e Compare June 12, 2025 09:30
@IriaAlonso
Copy link
Copy Markdown
Contributor Author

IriaAlonso commented Jun 12, 2025

@dalonsod can you review it?

@IriaAlonso IriaAlonso force-pushed the 17.0-add-sale_order_net_price_control branch 2 times, most recently from 6807ee4 to b4469b4 Compare June 13, 2025 10:34
@IriaAlonso
Copy link
Copy Markdown
Contributor Author

IriaAlonso commented Jun 13, 2025

@dalonsod

@IriaAlonso IriaAlonso force-pushed the 17.0-add-sale_order_net_price_control branch 4 times, most recently from be1ef49 to 6639c7a Compare June 16, 2025 07:48
dalonsod
dalonsod reviewed Jun 17, 2025
View reviewed changes
Comment thread sale_order_net_price_control/models/sale_order_line.py Outdated
dalonsod
dalonsod reviewed Jun 17, 2025
View reviewed changes
Comment thread sale_order_net_price_control/models/sale_order_line.py Outdated
dalonsod
dalonsod reviewed Jun 17, 2025
View reviewed changes
Comment thread sale_order_net_price_control/models/sale_order_line.py Outdated
@IriaAlonso IriaAlonso force-pushed the 17.0-add-sale_order_net_price_control branch from 6639c7a to 61897d3 Compare June 17, 2025 11:25
@IriaAlonso
Copy link
Copy Markdown
Contributor Author

IriaAlonso commented Jun 17, 2025

@dalonsod search moved to account.move.line and currency symbol removed

@IriaAlonso IriaAlonso force-pushed the 17.0-add-sale_order_net_price_control branch from 61897d3 to f005e3e Compare June 17, 2025 12:12
@dalonsod dalonsod marked this pull request as ready for review June 18, 2025 08:25
@dalonsod
Copy link
Copy Markdown
Contributor

dalonsod commented Jun 18, 2025

👍 I'll test it ASAP

dalonsod
dalonsod reviewed Oct 27, 2025
View reviewed changes
Comment thread sale_order_net_price_control/models/sale_order_line.py Outdated
@IriaAlonso IriaAlonso force-pushed the 17.0-add-sale_order_net_price_control branch from f005e3e to f83aed6 Compare October 28, 2025 08:06
dalonsod
dalonsod reviewed Oct 28, 2025
View reviewed changes
Comment thread sale_order_net_price_control/models/sale_order_line.py Outdated
@IriaAlonso IriaAlonso force-pushed the 17.0-add-sale_order_net_price_control branch from f83aed6 to 38754dc Compare October 28, 2025 09:32
@IriaAlonso
Copy link
Copy Markdown
Contributor Author

IriaAlonso commented Oct 28, 2025

@dalonsod changes done

dalonsod
dalonsod reviewed Nov 21, 2025
View reviewed changes
Comment thread sale_order_net_price_control/models/sale_order_line.py Outdated
@IriaAlonso IriaAlonso force-pushed the 17.0-add-sale_order_net_price_control branch from 38754dc to c837652 Compare November 24, 2025 14:12
@IriaAlonso IriaAlonso force-pushed the 17.0-add-sale_order_net_price_control branch from c837652 to 4a01e79 Compare December 3, 2025 08:54
@IriaAlonso
Copy link
Copy Markdown
Contributor Author

IriaAlonso commented Dec 3, 2025

@dalonsod con you review new changes?

  • compare MAYM pricelist without purchase invoice
  • Mark sale order line like offer if the product has especial price

@IriaAlonso
[ADD] sale_order_net_price_control
3b13c0c 
Controls the net price of the products when they are sold.
It has to be higher than the last price on a purchase invoice and higher than the lowest pricelist.
Allows users who are in the 'Sell Products at Any Price' group to bypass all controls.
@IriaAlonso IriaAlonso force-pushed the 17.0-add-sale_order_net_price_control branch from 4a01e79 to 3b13c0c Compare January 9, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalonsod dalonsod dalonsod requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IriaAlonso @dalonsod