Skip to content

fix(ci): provision tools for self-hosted checks - #18

Merged
somethingwithproof merged 1 commit into
mainfrom
fix/ci-toolchain-setup
Aug 22, 2026
Merged

fix(ci): provision tools for self-hosted checks#18
somethingwithproof merged 1 commit into
mainfrom
fix/ci-toolchain-setup

Conversation

@somethingwithproof

@somethingwithproof somethingwithproof commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • refresh the Terraform toolchain and run it on GitHub-hosted runners
  • install yamllint explicitly and run it directly instead of relying on the action entrypoint finding yamllint

Validation

  • parsed .github/workflows/ci.yaml with Python YAML loader
  • pre-commit hooks passed during commit

Summary by CodeRabbit

  • Chores
    • Updated continuous integration checks to use a Python-based YAML linting setup.
    • Standardized YAML validation for Argo CD configuration files.
    • Added consistent formatting rules, including line-length warnings and parser-friendly output.
    • Improved the reliability and consistency of automated configuration checks.

Toolchain upgrade

  • upgrade Terraform from 1.6.0 to 1.15.8 to use the currently supported CLI on the refreshed runner; validated with terraform fmt, init -backend=false, and validate in terraform/environments/dev

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9fff1a14-b6fa-41aa-b744-0250932f7db8

📥 Commits

Reviewing files that changed from the base of the PR and between 1a97638 and 77044d1.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml

📝 Walkthrough

Walkthrough

The yaml-lint CI job now provisions Python 3.12, installs yamllint 1.35.1, and runs it directly against argocd/ with inline rules.

Changes

CI YAML lint migration

Layer / File(s) Summary
YAML lint workflow execution
.github/workflows/ci.yaml
Replaces the ibiqlik/action-yamllint step with Python setup, pinned yamllint installation, inline rules, and parser-friendly output.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

I’m a bunny in the CI lane,
Python hops into the train.
YAML rules now check the stream,
Linting keeps the workflow clean.
Thump, thump—green is the dream!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the CI-focused change to provision missing tools for self-hosted checks.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-toolchain-setup

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI workflow to better support self-hosted runners by provisioning runtime dependencies needed by the Terraform and YAML linting steps.

Changes:

  • Add a Node.js setup step (Node 24) before running hashicorp/setup-terraform on the self-hosted runner.
  • Replace the ibiqlik/action-yamllint action with an explicit Python-based yamllint install and direct invocation.
  • Update the configured Terraform version used by CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yaml Outdated
Comment thread .github/workflows/ci.yaml Outdated
Comment thread .github/workflows/ci.yaml Outdated
Comment thread .github/workflows/ci.yaml Outdated
auto-merge was automatically disabled July 20, 2026 09:24

Head branch was pushed to by a user without write access

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yaml:
- Around line 68-69: Update the CI yamllint installation step to pin yamllint to
version 1.35.1, matching .pre-commit-config.yaml, and change the pre-commit
yamllint hook flag from -c to -d so the inline configuration is interpreted
correctly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2641ca7e-cedf-4594-a1c5-3dc5f553beee

📥 Commits

Reviewing files that changed from the base of the PR and between fb94032 and bb6bdc6.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml

Comment thread .github/workflows/ci.yaml Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/ci.yaml
@somethingwithproof
somethingwithproof enabled auto-merge (squash) July 20, 2026 21:24
@somethingwithproof

Copy link
Copy Markdown
Owner Author

@copilot Fix the code for all comments in this review thread.

When a review comment includes a suggested change, apply the suggestion exactly.

Do not make changes beyond what is described in the linked review thread.

Copilot AI commented Jul 20, 2026

Copy link
Copy Markdown

@copilot Fix the code for all comments in this review thread.

When a review comment includes a...

I checked the linked review thread (pullrequestreview-4734249011). The only code-related item there is already addressed by commit 1a97638, and no additional code changes are needed for that thread.

Run Terraform on a supported CLI, and install yamllint through Python rather
than relying on the action entrypoint to find it.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
@somethingwithproof
somethingwithproof merged commit 6bc9f87 into main Aug 22, 2026
6 of 7 checks passed
@somethingwithproof
somethingwithproof deleted the fix/ci-toolchain-setup branch August 22, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants