fix(ci): provision tools for self-hosted checks - #18
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesCI YAML lint migration
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow to better support self-hosted runners by provisioning runtime dependencies needed by the Terraform and YAML linting steps.
Changes:
- Add a Node.js setup step (Node 24) before running
hashicorp/setup-terraformon the self-hosted runner. - Replace the
ibiqlik/action-yamllintaction with an explicit Python-basedyamllintinstall and direct invocation. - Update the configured Terraform version used by CI.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yaml:
- Around line 68-69: Update the CI yamllint installation step to pin yamllint to
version 1.35.1, matching .pre-commit-config.yaml, and change the pre-commit
yamllint hook flag from -c to -d so the inline configuration is interpreted
correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2641ca7e-cedf-4594-a1c5-3dc5f553beee
📒 Files selected for processing (1)
.github/workflows/ci.yaml
|
@copilot Fix the code for all comments in this review thread. When a review comment includes a suggested change, apply the suggestion exactly. Do not make changes beyond what is described in the linked review thread. |
I checked the linked review thread ( |
Run Terraform on a supported CLI, and install yamllint through Python rather than relying on the action entrypoint to find it. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
1a97638 to
77044d1
Compare
Summary
Validation
Summary by CodeRabbit
Toolchain upgrade