Skip to content

Conversation

@eerison
Copy link
Contributor

@eerison eerison commented Nov 25, 2025

Fix small Symfony 7.3 deprecation

I am targeting this branch, because we will make 4.x version compatible with symfony 8

Issue #1837

Note: I can't test symfony 8, because most of the blocks related with this bundle is also blocking admin bundle, then I believe it is possible to fully test this bundle after admin bundle.

the first block was related with doctrine-bundle, But as I can see, Vicente is aware of this doctrine/DoctrineBundle#2113 (comment)

@eerison eerison marked this pull request as draft November 25, 2025 16:13
@eerison eerison force-pushed the symfony-7.x-deprecations branch 8 times, most recently from f54d984 to 10b8830 Compare November 26, 2025 11:56
Load config just after symfony 7.3

test xml
@eerison eerison force-pushed the symfony-7.x-deprecations branch from 10b8830 to 0c97064 Compare November 26, 2025 12:21
@eerison eerison force-pushed the symfony-7.x-deprecations branch from 4ccfbaf to 80551b7 Compare November 26, 2025 12:44
@eerison eerison marked this pull request as ready for review November 26, 2025 12:48
@eerison
Copy link
Contributor Author

eerison commented Nov 26, 2025

@dmaicher

Copy link
Contributor

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 I removed the changelog since this change does not affect users of the bundle

@dmaicher dmaicher merged commit 0e66606 into sonata-project:4.x Nov 26, 2025
26 checks passed
@dmaicher
Copy link
Contributor

Symfony 8 support is still blocked by some external packages like for example KnpLabs/KnpMenuBundle#500 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants