[Local-users-passwords-reset] Add new feature including config, yang and tests by azmy98 · Pull Request #18874 · sonic-net/sonic-buildimage

azmy98 · 2024-05-06T04:28:35Z

Depends on

sonic-net/sonic-platform-common#465

Why I did it

Added local-users-passwords-reset feature-related services according to HLD: sonic-net/SONiC#1577

Work item tracking

Microsoft ADO (number only):

How I did it

Added reset-local-users-passwords SystemD service
YANG model for new ConfDB table and YANG model tests.
Added config variable responsible for including the new service introduced

How to verify it

Manual test

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

linux-foundation-easycla · 2024-05-06T06:07:22Z

The committers listed above are authorized under a signed CLA.

✅ login: azmyali98 (f5ea07d, 657df13, afc5f19)

azmy98 · 2024-05-27T15:44:10Z

/azpw ms_conflict

azmy98 · 2024-09-23T06:34:17Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2024-09-23T06:34:19Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2024-09-23T06:34:31Z

Azure Pipelines successfully started running 1 pipeline(s).

liuh-80 · 2024-09-25T09:18:49Z

src/sonic-yang-models/tests/files/sample_config_db.json

            }
        }
    },
+    "LOCAL_USERS_PASSWORDS_RESET": {


Why this table dupe in config DB?

what do you suggest?

liuh-80 · 2024-09-25T09:24:58Z

src/sonic-yang-models/yang-models/sonic-local-users-passwords-reset.yang

+        description "First Revision";
+    }
+
+    container sonic-local-users-passwords-reset {


There is a "FEATURE" table for every feature config, maybe consider using that table?

why don't we need this table as well, this is the template right?

slave.mk

platform/mellanox/mlnx-platform-api/sonic_platform/local_users_passwords_reset.py

files/image_config/local-users-passwords-reset/local-users-passwords-reset.py

…s tests

FengPan-Frank · 2024-12-03T11:27:51Z

files/build_templates/sonic_debian_extension.j2

 echo "hostname-config.service" | sudo tee -a $GENERATED_SERVICE_FILE
 sudo cp $IMAGE_CONFIGS/hostname/hostname-config.sh $FILESYSTEM_ROOT/usr/bin/

+{% if enable_local_users_passwords_reset == "y" %}


do you need check sonic_asic_platform == "mellanox" as well?

No, why? it is not related to Mellanox or ASIC.. it is a general feature

ok I see, but I only saw local_users_passwords_reset.py for mellanox.

The implementation is for Mellanox, each vendor should add their implementation in case they want to use it same as we did in mellanox

mssonicbld · 2024-12-16T15:23:22Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2024-12-16T15:23:36Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2024-12-16T15:25:05Z

/azp run Azure.sonic-buildimage

mssonicbld · 2024-12-16T15:25:08Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2024-12-16T15:25:17Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2024-12-16T15:25:17Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2024-12-16T15:28:12Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2024-12-16T15:28:21Z

Azure Pipelines successfully started running 1 pipeline(s).

azmy98 requested review from lguohan and qiluo-msft as code owners May 6, 2024 04:28

azmy98 force-pushed the dev-reset-local-users-password branch 2 times, most recently from d051a6d to a9ec9e9 Compare May 6, 2024 04:31

azmy98 mentioned this pull request May 6, 2024

Adding the HLD for SONiC reset local users' passwords sonic-net/SONiC#1577

Merged

azmy98 force-pushed the dev-reset-local-users-password branch 5 times, most recently from 194a5a0 to 5b81bed Compare May 6, 2024 06:04

azmy98 force-pushed the dev-reset-local-users-password branch 14 times, most recently from f1f9c87 to a848ace Compare May 7, 2024 10:44

azmy98 requested a review from xumia as a code owner May 7, 2024 10:44

azmy98 force-pushed the dev-reset-local-users-password branch 4 times, most recently from 432ef6e to 96119a9 Compare May 7, 2024 18:08

azmy98 force-pushed the dev-reset-local-users-password branch 2 times, most recently from c1689a0 to 320f7bd Compare May 27, 2024 15:35

azmy98 force-pushed the dev-reset-local-users-password branch from 320f7bd to b887b6f Compare August 12, 2024 15:21

qiluo-msft requested review from liuh-80 and maipbui September 24, 2024 19:06

liuh-80 reviewed Sep 25, 2024

View reviewed changes

slave.mk Outdated Show resolved Hide resolved

maipbui reviewed Sep 27, 2024

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/local_users_passwords_reset.py Outdated Show resolved Hide resolved

maipbui reviewed Sep 27, 2024

View reviewed changes

files/image_config/local-users-passwords-reset/local-users-passwords-reset.py Outdated Show resolved Hide resolved

Adding local-users-passwords-reset feature service, YANG model and it…

f5ea07d

…s tests

azmy98 force-pushed the dev-reset-local-users-password branch from b887b6f to f5ea07d Compare November 27, 2024 09:34

FengPan-Frank reviewed Dec 3, 2024

View reviewed changes

Merge branch 'master' into dev-reset-local-users-password

657df13

azmy98 force-pushed the dev-reset-local-users-password branch from 5204429 to 657df13 Compare December 16, 2024 15:20

azmy98 force-pushed the dev-reset-local-users-password branch from f8dfa4e to 0d51e81 Compare December 16, 2024 15:23

Code review fixes

afc5f19

azmy98 force-pushed the dev-reset-local-users-password branch from 0d51e81 to afc5f19 Compare December 16, 2024 15:24

Conversation

azmy98 commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Depends on

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

linux-foundation-easycla bot commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azmy98 commented May 27, 2024

Uh oh!

azmy98 commented Sep 23, 2024

Uh oh!

mssonicbld commented Sep 23, 2024

Uh oh!

azure-pipelines bot commented Sep 23, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Dec 16, 2024

Uh oh!

azure-pipelines bot commented Dec 16, 2024

Uh oh!

mssonicbld commented Dec 16, 2024

Uh oh!

mssonicbld commented Dec 16, 2024

Uh oh!

azure-pipelines bot commented Dec 16, 2024

Uh oh!

azure-pipelines bot commented Dec 16, 2024

Uh oh!

mssonicbld commented Dec 16, 2024

Uh oh!

azure-pipelines bot commented Dec 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

azmy98 commented May 6, 2024 •

edited

Loading

linux-foundation-easycla bot commented May 6, 2024 •

edited

Loading