[Mellanox] Updated parse_vpd_data() to use inotify to wait for vpd_data creation#24882
Closed
zili11720 wants to merge 5 commits intosonic-net:masterfrom
Closed
[Mellanox] Updated parse_vpd_data() to use inotify to wait for vpd_data creation#24882zili11720 wants to merge 5 commits intosonic-net:masterfrom
zili11720 wants to merge 5 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Zili Bombach <zbombach@nvidia.com>
zili11720
force-pushed
the
inotify_vpd_data
branch
from
8e29b0b to
e174686
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zili11720
changed the title
dprital
approved these changes
Dec 18, 2025
keboliu
reviewed
Jan 20, 2026
|
|
||
| return self.vpd_data.get(REVISION, "N/A") | ||
|
|
||
| def _wait_for_file_creation(self, file_path, timeout): |
Collaborator
There was a problem hiding this comment.
Suggest adding this function to this file, https://github.com/sonic-net/sonic-buildimage/blob/master/platform/mellanox/mlnx-platform-api/sonic_platform/utils.py, it will be convinient to reuse this function in other files.
keboliu
reviewed
Jan 20, 2026
|
|
||
| return self.vpd_data.get(REVISION, "N/A") | ||
|
|
||
| def _wait_for_file_creation(self, file_path, timeout): |
Collaborator
There was a problem hiding this comment.
is it possible to add some unit tests for the new code?
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jianyuewu
approved these changes
Feb 11, 2026
zili11720
force-pushed
the
inotify_vpd_data
branch
from
9c36f9b to
298dbfa
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 24882 in repo sonic-net/sonic-buildimage |
Signed-off-by: Zili Bombach <zbombach@nvidia.com>
Signed-off-by: Zili Bombach <zbombach@nvidia.com>
zili11720
force-pushed
the
inotify_vpd_data
branch
from
0243fbf to
cd0094f
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
This PR is replaced by: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
This fixes a race condition where chassis.py attempts to access the VPD data file before it's available during system initialization. When the file doesn't exist yet, _parse_vpd_data() returns an empty dictionary, causing the revision field to be populated with "N/A" in Redis instead of the actual hardware revision value.
Work item tracking
How I did it
Update _parse_vpd_data() to use inotify mechanism to wait for VPD data file creation
before accessing it.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)