-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Tomahawk] Use legacy-th instead of legacy for Tomahawk image #25871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lipxu
wants to merge
5
commits into
sonic-net:master
Choose a base branch
from
lipxu:20260304_publicMaster_th
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+87
−87
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
13cbab6
Rename legacy directories to legacy-th for Tomahawk ASIC specificity
lipxu 7cd95e1
Rename legacy .mk files to legacy-th
lipxu 0a4eda8
Update all references from legacy to legacy-th
lipxu a7c8bc6
Fix Jinja2 variable name in docker-syncd-brcm-legacy-th Dockerfile
lipxu c0be07b
Replace broadcom-legacy with broadcom-legacy-th in platform validator
lipxu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| broadcom-legacy | ||
| broadcom-legacy-th |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # docker image for brcm-legacy-th syncd | ||
|
|
||
| DOCKER_SYNCD_LEGACY_TH_BASE = docker-syncd-brcm-legacy-th.gz | ||
| DOCKER_SYNCD_LEGACY_TH_BASE_DBG = docker-syncd-brcm-legacy-th-$(DBG_IMAGE_MARK).gz | ||
| DOCKER_SYNCD_LEGACY_TH_PLATFORM_CODE = brcm-legacy-th | ||
|
|
||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_PATH = $(PLATFORM_PATH)/docker-syncd-$(DOCKER_SYNCD_LEGACY_TH_PLATFORM_CODE) | ||
|
|
||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_LOAD_DOCKERS += $(DOCKER_CONFIG_ENGINE_BOOKWORM) | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_DBG_DEPENDS += $($(DOCKER_CONFIG_ENGINE_BOOKWORM)_DBG_DEPENDS) | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_DBG_IMAGE_PACKAGES = $($(DOCKER_CONFIG_ENGINE_BOOKWORM)_DBG_IMAGE_PACKAGES) | ||
|
|
||
| SONIC_DOCKER_IMAGES += $(DOCKER_SYNCD_LEGACY_TH_BASE) | ||
| ifneq ($(ENABLE_SYNCD_RPC),y) | ||
| SONIC_INSTALL_DOCKER_IMAGES += $(DOCKER_SYNCD_LEGACY_TH_BASE) | ||
| endif | ||
|
|
||
| SONIC_DOCKER_DBG_IMAGES += $(DOCKER_SYNCD_LEGACY_TH_BASE_DBG) | ||
| ifneq ($(ENABLE_SYNCD_RPC),y) | ||
| SONIC_INSTALL_DOCKER_DBG_IMAGES += $(DOCKER_SYNCD_LEGACY_TH_BASE_DBG) | ||
| endif | ||
|
|
||
|
|
||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_DEPENDS += $(SYNCD) | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_DEPENDS += $(BRCM_LEGACY_TH_SAI) | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_DEPENDS += $(SSWSYNCD) | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_FILES += $(RDB-CLI) | ||
|
|
||
| ifeq ($(INSTALL_DEBUG_TOOLS), y) | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_DBG_DEPENDS += $(SYNCD_DBG) \ | ||
| $(LIBSWSSCOMMON_DBG) \ | ||
| $(LIBSAIMETADATA_DBG) \ | ||
| $(LIBSAIREDIS_DBG) | ||
| endif | ||
|
|
||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_VERSION = 1.0.0 | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_PACKAGE_NAME = syncd-legacy-th | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_MACHINE = broadcom-legacy-th | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_AFTER = $(DOCKER_SYNCD_DNX_BASE) | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_CONTAINER_NAME = syncd | ||
|
|
||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_RUN_OPT += --privileged -t | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_RUN_OPT += -v /host/machine.conf:/etc/machine.conf | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_RUN_OPT += -v /etc/sonic:/etc/sonic:ro | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_RUN_OPT += -v /host/warmboot:/var/warmboot | ||
|
|
||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_BASE_IMAGE_FILES += bcmcmd:/usr/bin/bcmcmd | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_BASE_IMAGE_FILES += bcmsh:/usr/bin/bcmsh | ||
| $(DOCKER_SYNCD_LEGACY_TH_BASE)_BASE_IMAGE_FILES += bcm_common:/usr/bin/bcm_common | ||
|
|
||
| SONIC_BOOKWORM_DOCKERS += $(DOCKER_SYNCD_LEGACY_TH_BASE) | ||
| SONIC_BOOKWORM_DBG_DOCKERS += $(DOCKER_SYNCD_LEGACY_TH_BASE_DBG) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Broadcom LEGACY-TH SAI definitions | ||
| LIBSAIBCM_LEGACY_TH_VERSION = 13.2.1.100 | ||
| LIBSAIBCM_LEGACY_TH_BRANCH_NAME = SAI_13.2.1_compat_OCP1.17.1 | ||
|
|
||
| LIBSAIBCM_LEGACY_TH_URL_PREFIX = "https://packages.trafficmanager.net/public/sai/sai-broadcom/$(LIBSAIBCM_LEGACY_TH_BRANCH_NAME)/$(LIBSAIBCM_LEGACY_TH_VERSION)/xgs" | ||
|
|
||
| # SAI module for LEGACY-TH Asic family | ||
| BRCM_LEGACY_TH_SAI = libsaibcm_$(LIBSAIBCM_LEGACY_TH_VERSION)_amd64.deb | ||
| $(BRCM_LEGACY_TH_SAI)_URL = "$(LIBSAIBCM_LEGACY_TH_URL_PREFIX)/$(BRCM_LEGACY_TH_SAI)" | ||
|
|
||
| # Package registration | ||
| SONIC_ONLINE_DEBS += $(BRCM_LEGACY_TH_SAI) | ||
|
|
||
| # Version handling | ||
| $(BRCM_LEGACY_TH_SAI)_SKIP_VERSION=y | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package filename
libsaibcm_$(LIBSAIBCM_LEGACY_TH_VERSION)_amd64.debis identical to the one that was used in the deletedsai-legacy.mk(which also resolved tolibsaibcm_13.2.1.100_amd64.deb). Since both the oldBRCM_LEGACY_SAIand the newBRCM_LEGACY_TH_SAImap to the same.debfilename but are intended to be separate packages (one for legacy, one for legacy-th), there is a naming collision risk if both variables ever coexist or if the URL prefix resolves to the same artifact. Verify that the package filename and URL are indeed unique to the legacy-th variant, or add a-legacy-thsuffix to the package name (e.g.,libsaibcm-legacy-th_...) to clearly distinguish it.