[sonic-py-common]: Derive system MAC from base MAC for Micas platforms#28599
Open
ArthurMicas wants to merge 1 commit into
Open
[sonic-py-common]: Derive system MAC from base MAC for Micas platforms#28599ArthurMicas wants to merge 1 commit into
ArthurMicas wants to merge 1 commit into
Conversation
Signed-off-by: arthur <arthur@micasnetworks.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Micas platforms require the system MAC to be derived from the platform
base MAC plus one. This follows the platform MAC allocation requirement
and avoids using the unmodified base MAC as the system MAC.
Work item tracking
How I did it
elifso the MAC can be incremented at most once.How to verify it
Run the targeted unit tests:
python3 -m pytest tests/device_info_test.py -v -k get_system_mac_for_micasOn a Micas device, compare the platform base MAC with the configured
system MAC and verify that the system MAC is base MAC plus one. Actual
device MAC addresses are intentionally redacted.
Which release branch to backport (provide reason below if selected)
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO):
N/A
Failure type: N/A
Tested branch
Test result
python3 -m py_compile: PASSgit diff --check: PASSPR CI validation is pending.
base MAC plus one. Actual MAC addresses are redacted.
Description for the changelog
Derive the system MAC from the base MAC plus one on Micas platforms.
Link to config_db schema for YANG module changes
N/A