Skip to content

convert updates_only to suppress_redundant#581

Open
ronan-nexthop wants to merge 1 commit intosonic-net:masterfrom
nexthop-ai:suppressRedundant
Open

convert updates_only to suppress_redundant#581
ronan-nexthop wants to merge 1 commit intosonic-net:masterfrom
nexthop-ai:suppressRedundant

Conversation

@ronan-nexthop
Copy link
Contributor

Why I did it

This flag was incorrectly implemented.

See related part of gNMI spec at https://github.com/openconfig/reference/blob/master/rpc/gnmi/gnmi-specification.md#35152-stream-subscriptions

Optionally, the suppress_redundant field of the Subscription message may be set for a sampled subscription. In the case that it is set to true, the target SHOULD NOT generate a telemetry update message unless the value of the path being reported on has changed since the last update was generated. Updates MUST only be generated for those individual leaf nodes in the subscription that have changed.

On the other hand, upadtes_only effectively just means skip the initial sync and then send samples as per usual.

Note this will need changes to sonic-mgmt also, I am holding off on doing that until the gNMIC PR I have raised is merged as this will make things easier. Raising the PR now just to show it is a triaged issue.

How I did it

Made the same code flow look at the suppress redundant flag and not updates_only as it behaved in the way it should when the suppress_redundant flag is sent.

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 17, 2026

CLA Missing ID CLA Not Signed

@mssonicbld
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Ronan Mac Fhlannchadha <ronan@nexthop.ai>
@mssonicbld
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants