convert updates_only to suppress_redundant#581
Open
ronan-nexthop wants to merge 1 commit intosonic-net:masterfrom
Open
convert updates_only to suppress_redundant#581ronan-nexthop wants to merge 1 commit intosonic-net:masterfrom
ronan-nexthop wants to merge 1 commit intosonic-net:masterfrom
Conversation
|
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ronan Mac Fhlannchadha <ronan@nexthop.ai>
b9b40ef to
856c137
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
This flag was incorrectly implemented.
See related part of gNMI spec at https://github.com/openconfig/reference/blob/master/rpc/gnmi/gnmi-specification.md#35152-stream-subscriptions
On the other hand, upadtes_only effectively just means skip the initial sync and then send samples as per usual.
Note this will need changes to sonic-mgmt also, I am holding off on doing that until the gNMIC PR I have raised is merged as this will make things easier. Raising the PR now just to show it is a triaged issue.
How I did it
Made the same code flow look at the suppress redundant flag and not updates_only as it behaved in the way it should when the suppress_redundant flag is sent.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)