[action] [PR:583] Add support for PHY diagnostic parameters#599
Merged
mssonicbld merged 1 commit intosonic-net:202511from Mar 3, 2026
Merged
[action] [PR:583] Add support for PHY diagnostic parameters#599mssonicbld merged 1 commit intosonic-net:202511from
mssonicbld merged 1 commit intosonic-net:202511from
Conversation
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "fixes #xxxx", or
"closes #xxxx" or "resolves #xxxx"
Please provide the following information:
-->
#### Why I did it
Need to do the port OID to EthernetXX for this new table `PORT_PHY_ATTR` so that following PHY parameters can be streamed out of the sonic switch
rx_vga
pcs_fec_lane_alignment_lock
phy_rx_signal_detect
sonic-db-cli COUNTERS_DB hgetall "PORT_PHY_ATTR:oid:0x1000000000036"
{'rx_vga': ‘3:1,2,3’,
'tx_fir_taps_list': '[{tap1:-41,-20,80},{tap2:-2,10,22},{tap3:-21,2,22}]’,
'phy_rx_signal_detect': '{"0":"F*", "1":"T*", "2":"F*"}',
'pcs_fec_lane_alignment_lock': '{"0":"F*", "1":"F*", "2":"F*"}',
'rx_snr': '{"0":5385, "1":5385, "2":5385}'}
#### How I did it
Add corresponding oid mapping in db as well as mockup test cases.
#### How to verify it
#####Wildcard - all ports
gnmi_get -target_addr 127.0.0.1:50051 -xpath_target COUNTERS_DB -xpath "/PORT_PHY_ATTR/Ethernet*" -logtostderr -insecure true
<img width="2512" height="1027" alt="image" src="https://github.com/user-attachments/assets/55c45e71-7198-4b51-9369-73f785389f39" />
#####Single port
gnmi_get -target_addr 127.0.0.1:50051 -xpath_target COUNTERS_DB -xpath "/PORT_PHY_ATTR/Ethernet106" -logtostderr -insecure true
<img width="2497" height="701" alt="image" src="https://github.com/user-attachments/assets/21edfbad-c0f3-4fa9-87fb-0b1bafe52049" />
#### Which release branch to backport (provide reason below if selected)
<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->
- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->
#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/SONiC/wiki/Configuration.
-->
Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
#### A picture of a cute animal (not mandatory but encouraged)
Contributor
Author
|
Original PR: #583 |
6 tasks
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Need to do the port OID to EthernetXX for this new table
PORT_PHY_ATTRso that following PHY parameters can be streamed out of the sonic switchrx_vga
pcs_fec_lane_alignment_lock
phy_rx_signal_detect
sonic-db-cli COUNTERS_DB hgetall "PORT_PHY_ATTR:oid:0x1000000000036"
{'rx_vga': ‘3:1,2,3’,
'tx_fir_taps_list': '[{tap1:-41,-20,80},{tap2:-2,10,22},{tap3:-21,2,22}]’,
'phy_rx_signal_detect': '{"0":"F*", "1":"T*", "2":"F*"}',
'pcs_fec_lane_alignment_lock': '{"0":"F*", "1":"F*", "2":"F*"}',
'rx_snr': '{"0":5385, "1":5385, "2":5385}'}
How I did it
Add corresponding oid mapping in db as well as mockup test cases.
How to verify it
#####Wildcard - all ports
gnmi_get -target_addr 127.0.0.1:50051 -xpath_target COUNTERS_DB -xpath "/PORT_PHY_ATTR/Ethernet*" -logtostderr -insecure true
#####Single port
gnmi_get -target_addr 127.0.0.1:50051 -xpath_target COUNTERS_DB -xpath "/PORT_PHY_ATTR/Ethernet106" -logtostderr -insecure true
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com
A picture of a cute animal (not mandatory but encouraged)