Open
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes wildcard handling for PORT_PHY_ATTR virtual DB path translation so that <prefix>* only matches ports with the same prefix (instead of matching all ports whenever the key ends with *). This improves correctness of gNMI-to-Redis path expansion in sonic_data_client.
Changes:
- Update
v2rPortPhyAttrStatsandv2rPortPhyAttrFieldStatsto filter wildcard expansions by the requested key prefix. - Add unit tests verifying that
Ethernet*does not match non-Ethernetport keys, whileetp*does.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sonic_data_client/virtual_db.go | Adds prefix filtering for PORT_PHY_ATTR wildcard key expansion (<prefix>*). |
| sonic_data_client/virtual_db_test.go | Adds tests covering wildcard-prefix filtering behavior for both stats and field-stats variants. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)