Skip to content

[gNOI] Add support for gNOI Factory Reset #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VSuryaprasad-HCL
Copy link

@VSuryaprasad-HCL VSuryaprasad-HCL commented May 13, 2025

Manual CLI Testing Results

Start RPC

Since, the EXECUTE_BOOT_INSTALL_COMMAND is not being provided in the backend file [ gnoi_reset.py] . We're setting reset_success as false with detail string "boot count execution failed".

factory_os:

"admin@sonic:~$ docker exec gnmi gnoi_client -target 127.0.0.1:8080 -notls -module FactoryReset -rpc Start -jsonin '{""factoryOs"": true}'
Start Factory Reset.
{""Response"":{""ResetError"":{""other"":true,""detail"":""Failed to get the boot install value.""}}}"
"admin@sonic:~$ docker exec gnmi gnoi_client -target 127.0.0.1:8080 -notls -module FactoryReset -rpc Start -jsonin '{""factoryOs"": false}'
Start Factory Reset.
{""Response"":{""ResetError"":{""other"":true,""detail"":""Failed to get the boot install value.""}}}"

zero_fill:

"admin@sonic:~$ docker exec gnmi gnoi_client -target 127.0.0.1:8080 -notls -module FactoryReset -rpc Start -jsonin '{""factory_os"": true, ""zero_fill"": true}'
Start Factory Reset.
{""Response"":{""ResetError"":{""zero_fill_unsupported"":true,""detail"":""zero_fill operation is currently unsupported.""}}}"
"admin@sonic:~$ docker exec gnmi gnoi_client -target 127.0.0.1:8080 -notls -module FactoryReset -rpc Start -jsonin '{""factory_os"": true, ""zero_fill"": false}'
Start Factory Reset.
{""Response"":{""ResetError"":{""other"":true,""detail"":""Failed to get the boot install value.""}}}"

retainCerts:

"admin@sonic:~$ docker exec gnmi gnoi_client -target 127.0.0.1:8080 -notls -module FactoryReset -rpc Start -jsonin '{""factoryOs"": true, ""retainCerts"": true}'
Start Factory Reset.
{""Response"":{""ResetError"":{""other"":true,""detail"":""Failed to get the boot install value.""}}}"
"admin@sonic:~$ docker exec gnmi gnoi_client -target 127.0.0.1:8080 -notls -module FactoryReset -rpc Start -jsonin '{""factoryOs"": true, ""retainCerts"": false}'
Start Factory Reset.
{""Response"":{""ResetError"":{""other"":true,""detail"":""Failed to get the boot install value.""}}}"

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@VSuryaprasad-HCL VSuryaprasad-HCL changed the title [gNOI] Adding gNOI rest service. [gNOI] Add support for gNOI Factory Reset May 16, 2025
@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@VSuryaprasad-HCL
Copy link
Author

VSuryaprasad-HCL commented May 20, 2025

@ndas7 , @kishanps , @rkavitha-hcl could you please review the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants