Implement attribute based infra for transceiver onboarding by mihirpat1 · Pull Request #21042 · sonic-net/sonic-mgmt

mihirpat1 · 2025-10-20T22:09:30Z

Description of PR

Code changes to support the attribute infra per #20230 for onboarding transceivers

Summary:
Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

Code changes to support the attribute infra per #20230 for onboarding transceivers

How did you do it?

Add attribute_manager.py for layered attribute merging
Add config_parser.py for transceiver configuration parsing
Add dut_info_loader.py for DUT inventory loading
Add port_spec.py for port specification expansion
Add comprehensive test suite with 17 passing tests
Add conftest.py for test fixtures
Add a basic test to validate transceiver EEPROM
Added transceiver_attribute_infra_test.py file to manually test the attribute infrastructure. Usage details has been captured in the file itself

How did you verify/test it?

Ensured that the sonic-mgmt test passes

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

#20230

ADO - 35139411

mssonicbld · 2025-10-20T22:09:37Z

/azp run

azure-pipelines · 2025-10-20T22:09:51Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

This PR implements an attribute-based infrastructure for transceiver onboarding, introducing a layered configuration system that merges base port attributes with category-specific attributes (e.g., EEPROM) using a priority-based resolution mechanism. The infrastructure supports deployment template validation to ensure required attributes are present.

Key changes:

Multi-layer attribute merging system with 8 priority levels (defaults → platform → hwsku → deployment → vendor → part number → platform overrides → DUT-specific)
Port specification expansion supporting ranges, steps, and mixed formats
Comprehensive test suite with 17 tests validating core functionality and error scenarios

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/transceiver/infra/utils.py	Utility function for formatting nested dictionaries in log output
tests/transceiver/infra/test_transceiver_attribute_infra.py	Comprehensive test suite covering attribute loading, merging, validation, and error handling
tests/transceiver/infra/template_validator.py	Validates port attributes against deployment templates with compliance reporting
tests/transceiver/infra/port_spec.py	Expands port specifications (ranges, steps, lists) into individual port names
tests/transceiver/infra/paths.py	Centralized path constants for inventory structure
tests/transceiver/infra/exceptions.py	Custom exception classes for attribute infrastructure
tests/transceiver/infra/dut_info_loader.py	Loads and processes dut_info.json to build base port attributes
tests/transceiver/infra/config_parser.py	Parses transceiver configuration strings into structured components
tests/transceiver/infra/attribute_manager.py	Merges category attributes with base attributes using priority resolution
tests/transceiver/eeprom/test_eeprom_basic.py	Test validating EEPROM content via CLI against expected attributes
tests/transceiver/conftest.py	Pytest fixtures for attribute infrastructure initialization and validation

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tests/transceiver/infra/port_spec.py

mssonicbld · 2025-10-20T23:49:32Z

/azp run

azure-pipelines · 2025-10-20T23:49:46Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tests/transceiver/infra/exceptions.py

tests/transceiver/infra/template_validator.py

mssonicbld · 2025-10-21T00:10:47Z

/azp run

azure-pipelines · 2025-10-21T00:11:01Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-10-21T00:13:56Z

/azp run

azure-pipelines · 2025-10-21T00:14:09Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tests/transceiver/infra/template_validator.py

tests/transceiver/conftest.py

az-pz · 2025-10-22T21:47:44Z

tests/transceiver/infra/paths.py

+
+
+# Root directory (relative to repository root)
+REL_TRANSCEIVER_INV_DIR = os.path.join('ansible', 'files', 'transceiver', 'inventory')


Will it cause issue if the test is run from different directory? Have we thought about using pathlib.Path(__file__) and then traversing from there to get to the root directory?

@az-pz I have addressed this now

mssonicbld · 2025-10-24T20:56:44Z

/azp run

azure-pipelines · 2025-10-24T20:56:58Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-02T20:41:40Z

/azp run

azure-pipelines · 2026-01-02T20:41:53Z

Azure Pipelines successfully started running 1 pipeline(s).

- Add attribute_manager.py for layered attribute merging - Add config_parser.py for transceiver configuration parsing - Add dut_info_loader.py for DUT inventory loading - Add port_spec.py for port specification expansion - Add comprehensive test suite with 17 passing tests - Add eeprom attribute validation tests - Add conftest.py for test fixtures Signed-off-by: Mihir Patel <patelmi@microsoft.com>

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

mssonicbld · 2026-01-02T20:42:59Z

/azp run

azure-pipelines · 2026-01-02T20:43:15Z

Azure Pipelines successfully started running 1 pipeline(s).

tests/transceiver/eeprom/test_eeprom_basic.py

tests/transceiver/infra/attribute_manager.py

tests/transceiver/eeprom/test_eeprom_basic.py

mssonicbld · 2026-03-06T23:06:52Z

/azp run

azure-pipelines · 2026-03-06T23:07:08Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

mssonicbld · 2026-03-06T23:09:41Z

/azp run

azure-pipelines · 2026-03-06T23:09:56Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

mssonicbld · 2026-03-07T00:22:51Z

/azp run

azure-pipelines · 2026-03-07T00:23:07Z

Azure Pipelines successfully started running 1 pipeline(s).

mihirpat1 requested a review from Copilot October 20, 2025 22:09

Copilot AI reviewed Oct 20, 2025

View reviewed changes

tests/transceiver/infra/port_spec.py Outdated Show resolved Hide resolved

mihirpat1 requested a review from Copilot October 20, 2025 23:50

Copilot AI reviewed Oct 20, 2025

View reviewed changes

tests/transceiver/infra/exceptions.py Show resolved Hide resolved

tests/transceiver/infra/template_validator.py Outdated Show resolved Hide resolved

mihirpat1 force-pushed the transceiver-attribute-infra branch from 04c5faa to 7fc2181 Compare October 21, 2025 00:13

mihirpat1 requested a review from Copilot October 21, 2025 00:14

Copilot AI reviewed Oct 21, 2025

View reviewed changes

tests/transceiver/infra/template_validator.py Show resolved Hide resolved

tests/transceiver/conftest.py Show resolved Hide resolved

mihirpat1 marked this pull request as ready for review October 22, 2025 21:41

az-pz reviewed Oct 23, 2025

View reviewed changes

az-pz approved these changes Oct 28, 2025

View reviewed changes

mihirpat1 force-pushed the transceiver-attribute-infra branch from d12be9d to 473ca8a Compare January 2, 2026 20:41

github-actions bot requested review from rawal01, wangxin and xwjiang-ms January 2, 2026 20:41

mihirpat1 added 4 commits January 2, 2026 20:42

Fixed SA warnings

97f0fc2

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

Addressed copilot comments

a9531ee

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

Made path resolution more robust

fdd243d

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

Added code changes for dut_info.json file restructuring

a4d41df

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

mihirpat1 force-pushed the transceiver-attribute-infra branch from 473ca8a to a4d41df Compare January 2, 2026 20:42

roy-sror reviewed Feb 12, 2026

View reviewed changes

Addressed PR comment

e1bb47b

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

mihirpat1 force-pushed the transceiver-attribute-infra branch from 1e1be4b to e1bb47b Compare March 6, 2026 23:09

Added check for ptp-512 as part of test_eeprom_basic.py

ae1b0f7

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

prgeor approved these changes Mar 7, 2026

View reviewed changes

prgeor merged commit 25422ec into sonic-net:master Mar 7, 2026
13 of 14 checks passed



		# Root directory (relative to repository root)
		REL_TRANSCEIVER_INV_DIR = os.path.join('ansible', 'files', 'transceiver', 'inventory')

Conversation

mihirpat1 commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Oct 20, 2025

Uh oh!

azure-pipelines bot commented Oct 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

mssonicbld commented Oct 20, 2025

Uh oh!

azure-pipelines bot commented Oct 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Oct 21, 2025

Uh oh!

azure-pipelines bot commented Oct 21, 2025

Uh oh!

mssonicbld commented Oct 21, 2025

Uh oh!

azure-pipelines bot commented Oct 21, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

az-pz Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mihirpat1 Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Oct 24, 2025

Uh oh!

azure-pipelines bot commented Oct 24, 2025

Uh oh!

mssonicbld commented Jan 2, 2026

Uh oh!

azure-pipelines bot commented Jan 2, 2026

Uh oh!

mssonicbld commented Jan 2, 2026

Uh oh!

azure-pipelines bot commented Jan 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Mar 6, 2026

Uh oh!

azure-pipelines bot commented Mar 6, 2026

Uh oh!

mssonicbld commented Mar 6, 2026

Uh oh!

azure-pipelines bot commented Mar 6, 2026

Uh oh!

mssonicbld commented Mar 7, 2026

mihirpat1 commented Oct 20, 2025 •

edited

Loading

az-pz Oct 22, 2025 •

edited

Loading